diff --git a/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/EndpointWebMvcChildContextConfiguration.java b/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/EndpointWebMvcChildContextConfiguration.java index d47c25f44f..0b6dbd877f 100644 --- a/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/EndpointWebMvcChildContextConfiguration.java +++ b/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/EndpointWebMvcChildContextConfiguration.java @@ -151,7 +151,7 @@ public class EndpointWebMvcChildContextConfiguration { @Configuration @ConditionalOnClass({ EnableWebSecurity.class, Filter.class }) - @ConditionalOnBean(name = "springSecurityFilterChain", search = SearchStrategy.PARENTS) + @ConditionalOnBean(name = "springSecurityFilterChain", search = SearchStrategy.ANCESTORS) public static class EndpointWebMvcChildContextSecurityConfiguration { @Bean diff --git a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/OnBeanCondition.java b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/OnBeanCondition.java index 5ec455115b..34a43d2af5 100644 --- a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/OnBeanCondition.java +++ b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/OnBeanCondition.java @@ -126,7 +126,7 @@ class OnBeanCondition extends SpringBootCondition implements ConfigurationCondit private List getMatchingBeans(ConditionContext context, BeanSearchSpec beans) { ConfigurableListableBeanFactory beanFactory = context.getBeanFactory(); - if (beans.getStrategy() == SearchStrategy.PARENTS) { + if (beans.getStrategy() == SearchStrategy.ANCESTORS) { BeanFactory parent = beanFactory.getParentBeanFactory(); Assert.isInstanceOf(ConfigurableListableBeanFactory.class, parent, "Unable to use SearchStrategy.PARENTS"); diff --git a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/SearchStrategy.java b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/SearchStrategy.java index 74be38e6fa..41baa2e887 100644 --- a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/SearchStrategy.java +++ b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/SearchStrategy.java @@ -29,9 +29,9 @@ public enum SearchStrategy { CURRENT, /** - * Search all parents and ancestors, but not the current context. + * Search all ancestors, but not the current context. */ - PARENTS, + ANCESTORS, /** * Search the entire hierarchy. diff --git a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnMissingBeanTests.java b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnMissingBeanTests.java index ef48fa8e6b..350c652d27 100644 --- a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnMissingBeanTests.java +++ b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnMissingBeanTests.java @@ -258,7 +258,7 @@ public class ConditionalOnMissingBeanTests { } @Test - public void grandparentIsConsideredWhenUsingParentsStrategy() { + public void grandparentIsConsideredWhenUsingAncestorsStrategy() { this.context.register(ExampleBeanConfiguration.class); this.context.refresh(); AnnotationConfigApplicationContext parent = new AnnotationConfigApplicationContext(); @@ -267,7 +267,7 @@ public class ConditionalOnMissingBeanTests { AnnotationConfigApplicationContext child = new AnnotationConfigApplicationContext(); child.setParent(parent); child.register(ExampleBeanConfiguration.class, - OnBeanInParentsConfiguration.class); + OnBeanInAncestorsConfiguration.class); child.refresh(); assertThat(child.getBeansOfType(ExampleBean.class)).hasSize(1); child.close(); @@ -275,21 +275,21 @@ public class ConditionalOnMissingBeanTests { } @Test - public void currentContextIsIgnoredWhenUsingParentsStrategy() { + public void currentContextIsIgnoredWhenUsingAncestorsStrategy() { this.context.refresh(); AnnotationConfigApplicationContext child = new AnnotationConfigApplicationContext(); child.register(ExampleBeanConfiguration.class, - OnBeanInParentsConfiguration.class); + OnBeanInAncestorsConfiguration.class); child.setParent(this.context); child.refresh(); assertThat(child.getBeansOfType(ExampleBean.class)).hasSize(2); } @Configuration - protected static class OnBeanInParentsConfiguration { + protected static class OnBeanInAncestorsConfiguration { @Bean - @ConditionalOnMissingBean(search = SearchStrategy.PARENTS) + @ConditionalOnMissingBean(search = SearchStrategy.ANCESTORS) public ExampleBean exampleBean2() { return new ExampleBean("test"); } diff --git a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnSingleCandidateTests.java b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnSingleCandidateTests.java index 1877b70fbb..ec9bf8849c 100644 --- a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnSingleCandidateTests.java +++ b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnSingleCandidateTests.java @@ -63,11 +63,11 @@ public class ConditionalOnSingleCandidateTests { } @Test - public void singleCandidateInParentsOneCandidateInCurrent() { + public void singleCandidateInAncestorsOneCandidateInCurrent() { load(); AnnotationConfigApplicationContext child = new AnnotationConfigApplicationContext(); child.register(FooConfiguration.class, - OnBeanSingleCandidateInParentsConfiguration.class); + OnBeanSingleCandidateInAncestorsConfiguration.class); child.setParent(this.context); child.refresh(); assertThat(child.containsBean("baz")).isFalse(); @@ -75,10 +75,10 @@ public class ConditionalOnSingleCandidateTests { } @Test - public void singleCandidateInParentsOneCandidateInParent() { + public void singleCandidateInAncestorsOneCandidateInParent() { load(FooConfiguration.class); AnnotationConfigApplicationContext child = new AnnotationConfigApplicationContext(); - child.register(OnBeanSingleCandidateInParentsConfiguration.class); + child.register(OnBeanSingleCandidateInAncestorsConfiguration.class); child.setParent(this.context); child.refresh(); assertThat(child.containsBean("baz")).isTrue(); @@ -87,13 +87,13 @@ public class ConditionalOnSingleCandidateTests { } @Test - public void singleCandidateInParentsOneCandidateInGrandparent() { + public void singleCandidateInAncestorsOneCandidateInGrandparent() { load(FooConfiguration.class); AnnotationConfigApplicationContext parent = new AnnotationConfigApplicationContext(); parent.setParent(this.context); parent.refresh(); AnnotationConfigApplicationContext child = new AnnotationConfigApplicationContext(); - child.register(OnBeanSingleCandidateInParentsConfiguration.class); + child.register(OnBeanSingleCandidateInAncestorsConfiguration.class); child.setParent(parent); child.refresh(); assertThat(child.containsBean("baz")).isTrue(); @@ -177,8 +177,8 @@ public class ConditionalOnSingleCandidateTests { } @Configuration - @ConditionalOnSingleCandidate(value = String.class, search = SearchStrategy.PARENTS) - protected static class OnBeanSingleCandidateInParentsConfiguration { + @ConditionalOnSingleCandidate(value = String.class, search = SearchStrategy.ANCESTORS) + protected static class OnBeanSingleCandidateInAncestorsConfiguration { @Bean public String baz(String s) {