Configure HiddenHttpMethodFilter for Spring WebFlux

Closes gh-14008
This commit is contained in:
artsiom
2018-08-17 11:38:25 +02:00
committed by Brian Clozel
parent 22bc2bd7ba
commit 51fd27fad4
3 changed files with 91 additions and 0 deletions

View File

@@ -41,6 +41,7 @@ import org.springframework.boot.autoconfigure.web.ResourceProperties;
import org.springframework.boot.autoconfigure.web.format.WebConversionService;
import org.springframework.boot.context.properties.EnableConfigurationProperties;
import org.springframework.boot.web.codec.CodecCustomizer;
import org.springframework.boot.web.reactive.filter.OrderedHiddenHttpMethodFilter;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.Import;
@@ -55,6 +56,7 @@ import org.springframework.http.CacheControl;
import org.springframework.http.codec.ServerCodecConfigurer;
import org.springframework.util.ClassUtils;
import org.springframework.validation.Validator;
import org.springframework.web.filter.reactive.HiddenHttpMethodFilter;
import org.springframework.web.reactive.config.DelegatingWebFluxConfiguration;
import org.springframework.web.reactive.config.EnableWebFlux;
import org.springframework.web.reactive.config.ResourceChainRegistration;
@@ -80,6 +82,7 @@ import org.springframework.web.reactive.result.view.ViewResolver;
* @author Andy Wilkinson
* @author Phillip Webb
* @author Eddú Meléndez
* @author Artsiom Yudovin
* @since 2.0.0
*/
@Configuration
@@ -91,6 +94,12 @@ import org.springframework.web.reactive.result.view.ViewResolver;
@AutoConfigureOrder(Ordered.HIGHEST_PRECEDENCE + 10)
public class WebFluxAutoConfiguration {
@Bean
@ConditionalOnMissingBean(HiddenHttpMethodFilter.class)
public OrderedHiddenHttpMethodFilter hiddenHttpMethodFilter() {
return new OrderedHiddenHttpMethodFilter();
}
@Configuration
@EnableConfigurationProperties({ ResourceProperties.class, WebFluxProperties.class })
@Import({ EnableWebFluxConfiguration.class })

View File

@@ -30,6 +30,7 @@ import org.springframework.boot.autoconfigure.validation.ValidationAutoConfigura
import org.springframework.boot.autoconfigure.validation.ValidatorAdapter;
import org.springframework.boot.test.context.runner.ReactiveWebApplicationContextRunner;
import org.springframework.boot.web.codec.CodecCustomizer;
import org.springframework.boot.web.reactive.filter.OrderedHiddenHttpMethodFilter;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.core.Ordered;
@@ -41,6 +42,7 @@ import org.springframework.http.server.reactive.HttpHandler;
import org.springframework.test.util.ReflectionTestUtils;
import org.springframework.validation.Validator;
import org.springframework.validation.beanvalidation.LocalValidatorFactoryBean;
import org.springframework.web.filter.reactive.HiddenHttpMethodFilter;
import org.springframework.web.reactive.HandlerMapping;
import org.springframework.web.reactive.accept.RequestedContentTypeResolver;
import org.springframework.web.reactive.config.WebFluxConfigurationSupport;
@@ -66,6 +68,7 @@ import static org.mockito.Mockito.verify;
*
* @author Brian Clozel
* @author Andy Wilkinson
* @author Artsiom Yudovin
*/
public class WebFluxAutoConfigurationTests {
@@ -351,6 +354,22 @@ public class WebFluxAutoConfigurationTests {
});
}
@Test
public void hiddenHttpMethodFilterIsAutoConfigured() {
this.contextRunner.run((context) -> assertThat(context)
.hasSingleBean(OrderedHiddenHttpMethodFilter.class));
}
@Test
public void hiddenHttpMethodFilterCanBeOverridden() {
this.contextRunner.withUserConfiguration(CustomHiddenHttpMethodFilter.class)
.run((context) -> {
assertThat(context)
.doesNotHaveBean(OrderedHiddenHttpMethodFilter.class);
assertThat(context).hasSingleBean(HiddenHttpMethodFilter.class);
});
}
@Configuration
protected static class CustomArgumentResolvers {
@@ -456,4 +475,14 @@ public class WebFluxAutoConfigurationTests {
}
@Configuration
static class CustomHiddenHttpMethodFilter {
@Bean
public HiddenHttpMethodFilter customHiddenHttpMethodFilter() {
return mock(HiddenHttpMethodFilter.class);
}
}
}