Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't start containers imported via @ImportTestcontainers

Browse Source 
Remove early start of containers imported via `@ImportTestcontainers`
so that parallel startup can happen.

Fixes gh-38831
This commit is contained in:
Phillip Webb
2023-12-17 15:22:28 -08:00
parent 88429b6a66
commit 561c7f749b
2 changed files with 67 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-boot-project/spring-boot-testcontainers/src/main/java/org/springframework/boot/testcontainers/context/ContainerFieldsImporter.java
View File

@@ -22,7 +22,6 @@ import java.util.ArrayList;
import java.util.List;
import org.testcontainers.containers.Container;
import org.testcontainers.lifecycle.Startable;
import org.springframework.beans.factory.support.BeanDefinitionRegistry;
import org.springframework.util.Assert;
@@ -39,9 +38,6 @@ class ContainerFieldsImporter {
for (Field field : getContainerFields(definitionClass)) {
assertValid(field);
Container<?> container = getContainer(field);
if (container instanceof Startable startable) {
startable.start();
}
registerBeanDefinition(registry, field, container);
}
}