Fix class name in generated meta-data

Previously, the algorithm that computes the String representation of a
class reference and a property type was shared. This lead to generic
information for group's `type` and `sourceType` property.

This commit separates that logic in two: `getQualifiedName` is now
responsible to generate a fully qualified class name while the existing
`getType` is solely responsible to generate a type representation for the
property. Only the latter has generic information.

Closes gh-7236

spring-boot-tools/spring-boot-configuration-processor/src/test/java/org/springframework/boot/configurationprocessor/ConfigurationMetadataAnnotationProcessorTests.java

@@ -57,6 +57,7 @@ import org.springframework.boot.configurationsample.specific.BoxingPojo;
 import org.springframework.boot.configurationsample.specific.BuilderPojo;
 import org.springframework.boot.configurationsample.specific.DeprecatedUnrelatedMethodPojo;
 import org.springframework.boot.configurationsample.specific.ExcludedTypesPojo;
+import org.springframework.boot.configurationsample.specific.GenericConfig;
 import org.springframework.boot.configurationsample.specific.InnerClassAnnotatedGetterConfig;
 import org.springframework.boot.configurationsample.specific.InnerClassProperties;
 import org.springframework.boot.configurationsample.specific.InnerClassRootConfig;
@@ -339,6 +340,35 @@ public class ConfigurationMetadataAnnotationProcessorTests {
 		assertThat(metadata.getItems(), hasSize(1));
 	}
 
+	@Test
+	public void genericTypes() throws IOException {
+		ConfigurationMetadata metadata = compile(GenericConfig.class);
+		assertThat(metadata, containsGroup("generic").ofType(
+				"org.springframework.boot.configurationsample.specific.GenericConfig"));
+		assertThat(metadata, containsGroup("generic.foo").ofType(
+				"org.springframework.boot.configurationsample.specific.GenericConfig$Foo"));
+		assertThat(metadata, containsGroup("generic.foo.bar").ofType(
+				"org.springframework.boot.configurationsample.specific.GenericConfig$Bar"));
+		assertThat(metadata, containsGroup("generic.foo.bar.biz").ofType(
+				"org.springframework.boot.configurationsample.specific.GenericConfig$Bar$Biz"));
+		assertThat(metadata, containsProperty("generic.foo.name")
+				.ofType(String.class)
+				.fromSource(GenericConfig.Foo.class));
+		assertThat(metadata, containsProperty("generic.foo.string-to-bar")
+				.ofType("java.util.Map<java.lang.String,org.springframework.boot.configurationsample.specific.GenericConfig.Bar<java.lang.Integer>>")
+				.fromSource(GenericConfig.Foo.class));
+		assertThat(metadata, containsProperty("generic.foo.string-to-integer")
+				.ofType("java.util.Map<java.lang.String,java.lang.Integer>")
+				.fromSource(GenericConfig.Foo.class));
+		assertThat(metadata, containsProperty("generic.foo.bar.name")
+				.ofType("java.lang.String")
+				.fromSource(GenericConfig.Bar.class));
+		assertThat(metadata, containsProperty("generic.foo.bar.biz.name")
+				.ofType("java.lang.String")
+				.fromSource(GenericConfig.Bar.Biz.class));
+		assertThat(metadata.getItems(), hasSize(9));
+	}
+
 	@Test
 	public void lombokDataProperties() throws Exception {
 		ConfigurationMetadata metadata = compile(LombokSimpleDataProperties.class);

spring-boot-tools/spring-boot-configuration-processor/src/test/java/org/springframework/boot/configurationsample/specific/GenericConfig.java

@@ -0,0 +1,107 @@
+/*
+ * Copyright 2012-2016 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.boot.configurationsample.specific;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.springframework.boot.configurationsample.ConfigurationProperties;
+import org.springframework.boot.configurationsample.NestedConfigurationProperty;
+
+/**
+ * Demonstrate that only relevant generics are stored in the metadata.
+ *
+ * @author Stephane Nicoll
+ */
+@ConfigurationProperties("generic")
+public class GenericConfig<T> {
+
+	private final Foo foo = new Foo();
+
+	public Foo getFoo() {
+		return this.foo;
+	}
+
+	public static class Foo {
+
+		private String name;
+
+		@NestedConfigurationProperty
+		private final Bar<String> bar = new Bar<String>();
+
+		private final Map<String, Bar<Integer>> stringToBar =
+				new HashMap<String, Bar<Integer>>();
+
+		private final Map<String, Integer> stringToInteger =
+				new HashMap<String, Integer>();
+
+		public String getName() {
+			return this.name;
+		}
+
+		public void setName(String name) {
+			this.name = name;
+		}
+
+		public Bar<String> getBar() {
+			return this.bar;
+		}
+
+		public Map<String, Bar<Integer>> getStringToBar() {
+			return this.stringToBar;
+		}
+
+		public Map<String, Integer> getStringToInteger() {
+			return this.stringToInteger;
+		}
+	}
+
+	public static class Bar<U> {
+
+		private String name;
+
+		@NestedConfigurationProperty
+		private final Biz<String> biz = new Biz<String>();
+
+		public String getName() {
+			return this.name;
+		}
+
+		public void setName(String name) {
+			this.name = name;
+		}
+
+		public Biz<String> getBiz() {
+			return this.biz;
+		}
+
+		public static class Biz<V> {
+
+			private String name;
+
+			public String getName() {
+				return this.name;
+			}
+
+			public void setName(String name) {
+				this.name = name;
+			}
+		}
+
+	}
+
+}