Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid string concatenation inside StringBuilder append()

Browse Source 
See gh-15589
This commit is contained in:
igor-suhorukov
2018-12-30 22:34:02 +03:00
committed by Stephane Nicoll
parent 1b970b0ece
commit 59ac85d371
12 changed files with 45 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
spring-boot-project/spring-boot-cli/src/main/java/org/springframework/boot/cli/command/init/ServiceCapabilitiesReportGenerator.java
View File

@@ -66,9 +66,9 @@ class ServiceCapabilitiesReportGenerator {
private String generateHelp(String url, InitializrServiceMetadata metadata) {
String header = "Capabilities of " + url;
StringBuilder report = new StringBuilder();
report.append(repeat("=", header.length()) + NEW_LINE);
report.append(header + NEW_LINE);
report.append(repeat("=", header.length()) + NEW_LINE);
report.append(repeat("=", header.length())).append(NEW_LINE);
report.append(header).append(NEW_LINE);
report.append(repeat("=", header.length())).append(NEW_LINE);
report.append(NEW_LINE);
reportAvailableDependencies(metadata, report);
report.append(NEW_LINE);
@@ -80,13 +80,13 @@ class ServiceCapabilitiesReportGenerator {
private void reportAvailableDependencies(InitializrServiceMetadata metadata,
StringBuilder report) {
report.append("Available dependencies:" + NEW_LINE);
report.append("-----------------------" + NEW_LINE);
report.append("Available dependencies:").append(NEW_LINE);
report.append("-----------------------").append(NEW_LINE);
List<Dependency> dependencies = getSortedDependencies(metadata);
for (Dependency dependency : dependencies) {
report.append(dependency.getId() + " - " + dependency.getName());
report.append(dependency.getId()).append(" - ").append(dependency.getName());
if (dependency.getDescription() != null) {
report.append(": " + dependency.getDescription());
report.append(": ").append(dependency.getDescription());
}
report.append(NEW_LINE);
}
@@ -100,14 +100,14 @@ class ServiceCapabilitiesReportGenerator {
private void reportAvailableProjectTypes(InitializrServiceMetadata metadata,
StringBuilder report) {
report.append("Available project types:" + NEW_LINE);
report.append("------------------------" + NEW_LINE);
report.append("Available project types:").append(NEW_LINE);
report.append("------------------------").append(NEW_LINE);
SortedSet<Entry<String, ProjectType>> entries = new TreeSet<>(
Comparator.comparing(Entry::getKey));
entries.addAll(metadata.getProjectTypes().entrySet());
for (Entry<String, ProjectType> entry : entries) {
ProjectType type = entry.getValue();
report.append(entry.getKey() + " - " + type.getName());
report.append(entry.getKey()).append(" - ").append(type.getName());
if (!type.getTags().isEmpty()) {
reportTags(report, type);
}
@@ -124,7 +124,7 @@ class ServiceCapabilitiesReportGenerator {
report.append(" [");
while (iterator.hasNext()) {
Map.Entry<String, String> entry = iterator.next();
report.append(entry.getKey() + ":" + entry.getValue());
report.append(entry.getKey()).append(":").append(entry.getValue());
if (iterator.hasNext()) {
report.append(", ");
}
@@ -134,13 +134,14 @@ class ServiceCapabilitiesReportGenerator {
private void reportDefaults(StringBuilder report,
InitializrServiceMetadata metadata) {
report.append("Defaults:" + NEW_LINE);
report.append("---------" + NEW_LINE);
report.append("Defaults:").append(NEW_LINE);
report.append("---------").append(NEW_LINE);
List<String> defaultsKeys = new ArrayList<>(metadata.getDefaults().keySet());
Collections.sort(defaultsKeys);
for (String defaultsKey : defaultsKeys) {
String defaultsValue = metadata.getDefaults().get(defaultsKey);
report.append(defaultsKey + ": " + defaultsValue + NEW_LINE);
report.append(defaultsKey).append(": ").append(defaultsValue)
.append(NEW_LINE);
}
}