Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

More performance tweaks for SpringCli

Browse Source
This commit is contained in:
Dave Syer
2014-01-14 13:04:00 +00:00
parent e1605b4691
commit 5b90e18564
3 changed files with 56 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-boot-cli/src/test/java/org/springframework/boot/cli/SpringCliTests.java
View File

@@ -117,7 +117,7 @@ public class SpringCliTests {
this.cli.register(this.anotherCommand);
assertEquals(before + 1, this.cli.getCommands().size());
// Just before the hint command
assertEquals(before - 2, this.cli.getCommands().indexOf(this.cli.find("another")));
assertEquals(before - 1, this.cli.getCommands().indexOf(this.cli.find("another")));
this.cli.unregister(this.anotherCommand.getName());
assertEquals(before, this.cli.getCommands().size());
}

25
spring-boot-cli/src/test/java/org/springframework/boot/cli/command/InitCommandPerformanceTests.java
View File

@@ -28,8 +28,6 @@ import org.springframework.boot.cli.Command;
import org.springframework.boot.cli.CommandFactory;
import org.springframework.boot.cli.SpringCli;
import static org.mockito.Mockito.mock;
/**
* @author Dave Syer
*/
@@ -37,7 +35,6 @@ public class InitCommandPerformanceTests {
@Rule
public OutputCapture output = new OutputCapture();
private SpringCli cli = mock(SpringCli.class);
private ClassLoader classLoader;
private Random random = new Random();
@@ -54,7 +51,8 @@ public class InitCommandPerformanceTests {
@Test
public void initDefault() throws Exception {
for (int i = 0; i < 100; i++) {
InitCommand command = new InitCommand(this.cli);
SpringCli cli = new SpringCli();
InitCommand command = new InitCommand(cli);
command.run();
close();
}
@@ -64,7 +62,8 @@ public class InitCommandPerformanceTests {
// Fast...
public void initNonExistent() throws Exception {
for (int i = 0; i < 100; i++) {
InitCommand command = new InitCommand(this.cli);
SpringCli cli = new SpringCli();
InitCommand command = new InitCommand(cli);
command.run("--init=" + this.random.nextInt() + ".groovy");
close();
}
@@ -73,6 +72,7 @@ public class InitCommandPerformanceTests {
@Test
// Fast...
public void fakeCommand() throws Exception {
final SpringCli cli = new SpringCli();
for (int i = 0; i < 100; i++) {
Command command = new AbstractCommand("fake", "") {
@Override
@@ -80,9 +80,8 @@ public class InitCommandPerformanceTests {
for (CommandFactory factory : ServiceLoader.load(
CommandFactory.class, Thread.currentThread()
.getContextClassLoader())) {
for (Command command : factory
.getCommands(InitCommandPerformanceTests.this.cli)) {
InitCommandPerformanceTests.this.cli.register(command);
for (Command command : factory.getCommands(cli)) {
cli.register(command);
}
}
}
@@ -96,7 +95,8 @@ public class InitCommandPerformanceTests {
// Fast...
public void initNonExistentWithPrefix() throws Exception {
for (int i = 0; i < 100; i++) {
InitCommand command = new InitCommand(this.cli);
SpringCli cli = new SpringCli();
InitCommand command = new InitCommand(cli);
command.run("--init=file:" + this.random.nextInt() + ".groovy");
close();
}
@@ -107,10 +107,15 @@ public class InitCommandPerformanceTests {
// Slow...
public void initFromClasspath() throws Exception {
for (int i = 0; i < 5; i++) {
InitCommand command = new InitCommand(this.cli);
SpringCli cli = new SpringCli();
InitCommand command = new InitCommand(cli);
command.run("--init=init.groovy");
close();
}
}
public static void main(String[] args) {
SpringCli.main("hint");
}
}