From 6086e81ccd742a7a94faacc1552f6bba30b6dc6a Mon Sep 17 00:00:00 2001 From: Christoph Dreis Date: Wed, 10 May 2023 07:25:02 +0200 Subject: [PATCH] Fix configuring replica set via PropertiesMongoConnectionDetails See gh-35370 --- .../PropertiesMongoConnectionDetails.java | 2 +- ...PropertiesMongoConnectionDetailsTests.java | 49 +++++++++++++++++++ 2 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/mongo/PropertiesMongoConnectionDetailsTests.java diff --git a/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/mongo/PropertiesMongoConnectionDetails.java b/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/mongo/PropertiesMongoConnectionDetails.java index f627bf04d0..4d6fb5c3d1 100644 --- a/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/mongo/PropertiesMongoConnectionDetails.java +++ b/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/mongo/PropertiesMongoConnectionDetails.java @@ -66,7 +66,7 @@ public class PropertiesMongoConnectionDetails implements MongoConnectionDetails } if (this.properties.getReplicaSetName() != null) { builder.append("?"); - builder.append("repliceSet="); + builder.append("replicaSet="); builder.append(this.properties.getReplicaSetName()); } } diff --git a/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/mongo/PropertiesMongoConnectionDetailsTests.java b/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/mongo/PropertiesMongoConnectionDetailsTests.java new file mode 100644 index 0000000000..2f9887f468 --- /dev/null +++ b/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/mongo/PropertiesMongoConnectionDetailsTests.java @@ -0,0 +1,49 @@ +/* + * Copyright 2012-2023 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.springframework.boot.autoconfigure.mongo; + +import com.mongodb.ConnectionString; +import org.junit.jupiter.api.Test; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Tests for {@link PropertiesMongoConnectionDetails}. + * + * @author Christoph Dreis + */ +class PropertiesMongoConnectionDetailsTests { + + private final MongoProperties properties = new MongoProperties(); + + @Test + void replicaSetCanBeConfigured() { + this.properties.setReplicaSetName("test"); + ConnectionString connectionString = getConnectionString(); + assertThat(connectionString.getRequiredReplicaSetName()).isEqualTo("test"); + } + + private PropertiesMongoConnectionDetails createConnectionDetails() { + return new PropertiesMongoConnectionDetails(this.properties); + } + + private ConnectionString getConnectionString() { + PropertiesMongoConnectionDetails connectionDetails = createConnectionDetails(); + return connectionDetails.getConnectionString(); + } + +}