diff --git a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/reactive/EndpointRequest.java b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/reactive/EndpointRequest.java index 0097d5299a..50dc4a97d8 100644 --- a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/reactive/EndpointRequest.java +++ b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/reactive/EndpointRequest.java @@ -1,5 +1,5 @@ /* - * Copyright 2012-2020 the original author or authors. + * Copyright 2012-2023 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -226,6 +226,27 @@ public final class EndpointRequest { return source.stream().filter(Objects::nonNull).map(this::getEndpointId).map(pathMappedEndpoints::getPath); } + @Override + protected Mono matches(ServerWebExchange exchange, Supplier context) { + return this.delegate.matches(exchange); + } + + private List getDelegateMatchers(Set paths) { + return paths.stream().map((path) -> new PathPatternParserServerWebExchangeMatcher(path + "/**")) + .collect(Collectors.toList()); + } + + @Override + public String toString() { + return String.format("EndpointRequestMatcher includes=%s, excludes=%s, includeLinks=%s", + toString(this.includes, "[*]"), toString(this.excludes, "[]"), this.includeLinks); + } + + private String toString(List endpoints, String emptyValue) { + return (!endpoints.isEmpty()) ? endpoints.stream().map(this::getEndpointId).map(Object::toString) + .collect(Collectors.joining(", ", "[", "]")) : emptyValue; + } + private EndpointId getEndpointId(Object source) { if (source instanceof EndpointId) { return (EndpointId) source; @@ -245,16 +266,6 @@ public final class EndpointRequest { return EndpointId.of(annotation.getString("id")); } - private List getDelegateMatchers(Set paths) { - return paths.stream().map((path) -> new PathPatternParserServerWebExchangeMatcher(path + "/**")) - .collect(Collectors.toList()); - } - - @Override - protected Mono matches(ServerWebExchange exchange, Supplier context) { - return this.delegate.matches(exchange); - } - } /** diff --git a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequest.java b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequest.java index 69afad4091..5cf798ea84 100644 --- a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequest.java +++ b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequest.java @@ -1,5 +1,5 @@ /* - * Copyright 2012-2020 the original author or authors. + * Copyright 2012-2023 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -248,6 +248,23 @@ public final class EndpointRequest { return source.stream().filter(Objects::nonNull).map(this::getEndpointId).map(pathMappedEndpoints::getPath); } + private List getDelegateMatchers(RequestMatcherFactory requestMatcherFactory, + RequestMatcherProvider matcherProvider, Set paths) { + return paths.stream().map((path) -> requestMatcherFactory.antPath(matcherProvider, path, "/**")) + .collect(Collectors.toList()); + } + + @Override + public String toString() { + return String.format("EndpointRequestMatcher includes=%s, excludes=%s, includeLinks=%s", + toString(this.includes, "[*]"), toString(this.excludes, "[]"), this.includeLinks); + } + + private String toString(List endpoints, String emptyValue) { + return (!endpoints.isEmpty()) ? endpoints.stream().map(this::getEndpointId).map(Object::toString) + .collect(Collectors.joining(", ", "[", "]")) : emptyValue; + } + private EndpointId getEndpointId(Object source) { if (source instanceof EndpointId) { return (EndpointId) source; @@ -267,30 +284,6 @@ public final class EndpointRequest { return EndpointId.of(annotation.getString("id")); } - private List getDelegateMatchers(RequestMatcherFactory requestMatcherFactory, - RequestMatcherProvider matcherProvider, Set paths) { - return paths.stream().map((path) -> requestMatcherFactory.antPath(matcherProvider, path, "/**")) - .collect(Collectors.toList()); - } - - @Override - public String toString() { - StringBuilder sb = new StringBuilder(); - if (this.includes.isEmpty()) { - sb.append("EndpointRequest [includes='[").append("*").append("]'"); - } - else { - sb.append("EndpointRequest [includes='") - .append(this.includes.stream().map(this::getEndpointId).collect(Collectors.toList())) - .append("'"); - } - sb.append(", Excludes='") - .append(this.excludes.stream().map(this::getEndpointId).collect(Collectors.toList())).append("'"); - sb.append(", IncludeLinks='").append(this.includeLinks).append("'"); - sb.append("]"); - return sb.toString(); - } - } /** diff --git a/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/security/reactive/EndpointRequestTests.java b/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/security/reactive/EndpointRequestTests.java index bcc85a8d7c..a3dce33bb2 100644 --- a/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/security/reactive/EndpointRequestTests.java +++ b/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/security/reactive/EndpointRequestTests.java @@ -1,5 +1,5 @@ /* - * Copyright 2012-2019 the original author or authors. + * Copyright 2012-2023 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -188,6 +188,30 @@ class EndpointRequestTests { assertMatcher(matcher, (PathMappedEndpoints) null).doesNotMatch("/actuator/bar"); } + @Test + void toStringWhenIncludedEndpoints() { + ServerWebExchangeMatcher matcher = EndpointRequest.to("foo", "bar"); + assertThat(matcher).hasToString("EndpointRequestMatcher includes=[foo, bar], excludes=[], includeLinks=false"); + } + + @Test + void toStringWhenEmptyIncludedEndpoints() { + ServerWebExchangeMatcher matcher = EndpointRequest.toAnyEndpoint(); + assertThat(matcher).hasToString("EndpointRequestMatcher includes=[*], excludes=[], includeLinks=true"); + } + + @Test + void toStringWhenIncludedEndpointsClasses() { + ServerWebExchangeMatcher matcher = EndpointRequest.to(FooEndpoint.class).excluding("bar"); + assertThat(matcher).hasToString("EndpointRequestMatcher includes=[foo], excludes=[bar], includeLinks=false"); + } + + @Test + void toStringWhenIncludedExcludedEndpoints() { + ServerWebExchangeMatcher matcher = EndpointRequest.toAnyEndpoint().excluding("bar").excludingLinks(); + assertThat(matcher).hasToString("EndpointRequestMatcher includes=[*], excludes=[bar], includeLinks=false"); + } + private RequestMatcherAssert assertMatcher(ServerWebExchangeMatcher matcher) { return assertMatcher(matcher, mockPathMappedEndpoints("/actuator")); } diff --git a/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequestTests.java b/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequestTests.java index 7bb3cf50c3..72cf454efe 100644 --- a/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequestTests.java +++ b/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequestTests.java @@ -1,5 +1,5 @@ /* - * Copyright 2012-2019 the original author or authors. + * Copyright 2012-2023 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -217,31 +217,27 @@ class EndpointRequestTests { } @Test - void toStringIncludedEndpoints() { + void toStringWhenIncludedEndpoints() { RequestMatcher matcher = EndpointRequest.to("foo", "bar"); - assertThat(matcher.toString()) - .isEqualTo("EndpointRequest [includes='[foo, bar]', Excludes='[]', IncludeLinks='false']"); + assertThat(matcher).hasToString("EndpointRequestMatcher includes=[foo, bar], excludes=[], includeLinks=false"); } @Test - void toStringEmptyIncludedEndpoints() { + void toStringWhenEmptyIncludedEndpoints() { RequestMatcher matcher = EndpointRequest.toAnyEndpoint(); - assertThat(matcher.toString()) - .isEqualTo("EndpointRequest [includes='[*]', Excludes='[]', IncludeLinks='true']"); + assertThat(matcher).hasToString("EndpointRequestMatcher includes=[*], excludes=[], includeLinks=true"); } @Test - void toStringIncludedEndpointsClasses() { + void toStringWhenIncludedEndpointsClasses() { RequestMatcher matcher = EndpointRequest.to(FooEndpoint.class).excluding("bar"); - assertThat(matcher.toString()) - .isEqualTo("EndpointRequest [includes='[foo]', Excludes='[bar]', IncludeLinks='false']"); + assertThat(matcher).hasToString("EndpointRequestMatcher includes=[foo], excludes=[bar], includeLinks=false"); } @Test - void toStringIncludedExcludedEndpoints() { + void toStringWhenIncludedExcludedEndpoints() { RequestMatcher matcher = EndpointRequest.toAnyEndpoint().excluding("bar").excludingLinks(); - assertThat(matcher.toString()) - .isEqualTo("EndpointRequest [includes='[*]', Excludes='[bar]', IncludeLinks='false']"); + assertThat(matcher).hasToString("EndpointRequestMatcher includes=[*], excludes=[bar], includeLinks=false"); } private RequestMatcherAssert assertMatcher(RequestMatcher matcher) {