From 43acc37587977b18a3eb27c6aff716e904e320e6 Mon Sep 17 00:00:00 2001 From: Hiroaki Yoshida Date: Mon, 20 Aug 2018 16:47:16 -0700 Subject: [PATCH 1/2] Fix String concatenation in a loop See gh-14153 --- .../autoconfigure/security/servlet/EndpointRequest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequest.java b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequest.java index ac6413006f..4f65bb3c67 100644 --- a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequest.java +++ b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequest.java @@ -317,11 +317,11 @@ public final class EndpointRequest { public RequestMatcher antPath(RequestMatcherProvider matcherProvider, String... parts) { - String pattern = this.prefix; + StringBuffer pattern = new StringBuffer(this.prefix); for (String part : parts) { - pattern += part; + pattern.append(part); } - return matcherProvider.getRequestMatcher(pattern); + return matcherProvider.getRequestMatcher(pattern.toString()); } } From 000cb943238947fec086ac7f64054182b7a1c9b9 Mon Sep 17 00:00:00 2001 From: Stephane Nicoll Date: Wed, 22 Aug 2018 10:47:05 +0200 Subject: [PATCH 2/2] Polish "Fix String concatenation in a loop" Closes gh-14153 --- .../actuate/autoconfigure/security/servlet/EndpointRequest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequest.java b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequest.java index 4f65bb3c67..f3633bd7b1 100644 --- a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequest.java +++ b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequest.java @@ -317,7 +317,7 @@ public final class EndpointRequest { public RequestMatcher antPath(RequestMatcherProvider matcherProvider, String... parts) { - StringBuffer pattern = new StringBuffer(this.prefix); + StringBuilder pattern = new StringBuilder(this.prefix); for (String part : parts) { pattern.append(part); }