Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix handling of jar files with + chars in their path

Browse Source 
Closes gh-17208
This commit is contained in:
Andy Wilkinson
2019-06-17 10:31:51 +01:00
parent 4894affbb6
commit 7d59b78829
2 changed files with 30 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
spring-boot-project/spring-boot-tools/spring-boot-loader/src/test/java/org/springframework/boot/loader/jar/HandlerTests.java
View File

@@ -167,6 +167,34 @@ public class HandlerTests {
assertThat(jdkConnection).isNotInstanceOf(JarURLConnection.class);
}
@Test
public void whenJarHasAPlusInItsPathConnectionJarFileMatchesOriginalJarFile() throws Exception {
File testJar = this.temporaryFolder.newFile("t+e+s+t.jar");
TestJarCreator.createTestJar(testJar);
URL url = new URL(null, "jar:" + testJar.toURI().toURL() + "!/nested.jar!/3.dat", this.handler);
JarURLConnection connection = (JarURLConnection) url.openConnection();
try {
assertThat(connection.getJarFile().getRootJarFile().getFile()).isEqualTo(testJar);
}
finally {
connection.getJarFile().close();
}
}
@Test
public void whenJarHasASpaceInItsPathConnectionJarFileMatchesOriginalJarFile() throws Exception {
File testJar = this.temporaryFolder.newFile("t e s t.jar");
TestJarCreator.createTestJar(testJar);
URL url = new URL(null, "jar:" + testJar.toURI().toURL() + "!/nested.jar!/3.dat", this.handler);
JarURLConnection connection = (JarURLConnection) url.openConnection();
try {
assertThat(connection.getJarFile().getRootJarFile().getFile()).isEqualTo(testJar);
}
finally {
connection.getJarFile().close();
}
}
private void assertStandardAndCustomHandlerUrlsAreEqual(String context, String spec) throws MalformedURLException {
URL standardUrl = new URL(new URL("jar:" + context), spec);
URL customHandlerUrl = new URL(new URL("jar", null, -1, context, this.handler), spec);