Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use file urls for unpacked jars

Browse Source 
Update `JarFileArchive` so that unpacked jars use `file:` URLs rather
than `jar:file:`. This aligns with the behavior of Spring Boot 3.1 and
allows calls to `class.getSigners()` to work again.

Fixes gh-38833
This commit is contained in:
Phillip Webb
2023-12-17 10:53:52 -08:00
parent 3d42dc7c6d
commit 88429b6a66
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-boot-project/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/launch/JarFileArchive.java
View File

@@ -113,7 +113,7 @@ class JarFileArchive implements Archive {
if (!Files.exists(path) || Files.size(path) != jarEntry.getSize()) {
unpack(jarEntry, path);
}
return JarUrl.create(path.toFile());
return path.toUri().toURL();
}
private Path getTempUnpackDirectory() {

3
spring-boot-project/spring-boot-tools/spring-boot-loader/src/test/java/org/springframework/boot/loader/launch/JarFileArchiveTests.java
View File

@@ -112,7 +112,8 @@ class JarFileArchiveTests {
assertThat(urls).hasSize(1);
URL url = urls.iterator().next();
assertThat(url).isNotEqualTo(JarUrl.create(this.file, "nested.jar"));
assertThat(url.toString()).startsWith("jar:file:").endsWith("/nested.jar!/");
// The unpack URL must be a raw file URL (see gh-38833)
assertThat(url.toString()).startsWith("file:").endsWith("/nested.jar").doesNotStartWith("jar:");
}
@Test