diff --git a/spring-boot-project/spring-boot-test-autoconfigure/src/main/java/org/springframework/boot/test/autoconfigure/web/servlet/SpringBootMockMvcBuilderCustomizer.java b/spring-boot-project/spring-boot-test-autoconfigure/src/main/java/org/springframework/boot/test/autoconfigure/web/servlet/SpringBootMockMvcBuilderCustomizer.java index 2b137a2296..24f2afb7f3 100644 --- a/spring-boot-project/spring-boot-test-autoconfigure/src/main/java/org/springframework/boot/test/autoconfigure/web/servlet/SpringBootMockMvcBuilderCustomizer.java +++ b/spring-boot-project/spring-boot-test-autoconfigure/src/main/java/org/springframework/boot/test/autoconfigure/web/servlet/SpringBootMockMvcBuilderCustomizer.java @@ -29,9 +29,7 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.springframework.beans.factory.NoSuchBeanDefinitionException; -import org.springframework.boot.web.servlet.DelegatingFilterProxyRegistrationBean; -import org.springframework.boot.web.servlet.FilterRegistrationBean; -import org.springframework.boot.web.servlet.ServletContextInitializer; +import org.springframework.boot.web.servlet.AbstractFilterRegistrationBean; import org.springframework.boot.web.servlet.ServletContextInitializerBeans; import org.springframework.context.ApplicationContext; import org.springframework.context.ConfigurableApplicationContext; @@ -108,24 +106,11 @@ public class SpringBootMockMvcBuilderCustomizer implements MockMvcBuilderCustomi private void addFilters(ConfigurableMockMvcBuilder builder) { ServletContextInitializerBeans initializers = new ServletContextInitializerBeans( this.context); - for (ServletContextInitializer initializer : initializers) { - if (initializer instanceof FilterRegistrationBean) { - addFilter(builder, (FilterRegistrationBean) initializer); - } - if (initializer instanceof DelegatingFilterProxyRegistrationBean) { - addFilter(builder, (DelegatingFilterProxyRegistrationBean) initializer); - } - } - } - - private void addFilter(ConfigurableMockMvcBuilder builder, - FilterRegistrationBean registration) { - addFilter(builder, registration.getFilter(), registration.getUrlPatterns()); - } - - private void addFilter(ConfigurableMockMvcBuilder builder, - DelegatingFilterProxyRegistrationBean registration) { - addFilter(builder, registration.getFilter(), registration.getUrlPatterns()); + initializers.stream().filter(AbstractFilterRegistrationBean.class::isInstance) + .map(AbstractFilterRegistrationBean.class::cast) + .filter(AbstractFilterRegistrationBean::isEnabled) + .forEach((registration) -> addFilter(builder, registration.getFilter(), + registration.getUrlPatterns())); } private void addFilter(ConfigurableMockMvcBuilder builder, Filter filter, diff --git a/spring-boot-project/spring-boot-test-autoconfigure/src/test/java/org/springframework/boot/test/autoconfigure/web/servlet/mockmvc/WebMvcTestServletFilterRegistrationDisabledIntegrationTests.java b/spring-boot-project/spring-boot-test-autoconfigure/src/test/java/org/springframework/boot/test/autoconfigure/web/servlet/mockmvc/WebMvcTestServletFilterRegistrationDisabledIntegrationTests.java new file mode 100644 index 0000000000..10fbc099ee --- /dev/null +++ b/spring-boot-project/spring-boot-test-autoconfigure/src/test/java/org/springframework/boot/test/autoconfigure/web/servlet/mockmvc/WebMvcTestServletFilterRegistrationDisabledIntegrationTests.java @@ -0,0 +1,64 @@ +/* + * Copyright 2012-2018 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.springframework.boot.test.autoconfigure.web.servlet.mockmvc; + +import org.junit.Test; +import org.junit.runner.RunWith; + +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest; +import org.springframework.boot.test.context.TestConfiguration; +import org.springframework.boot.web.servlet.FilterRegistrationBean; +import org.springframework.context.annotation.Bean; +import org.springframework.test.context.junit4.SpringRunner; +import org.springframework.test.web.servlet.MockMvc; + +import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get; +import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.header; + +/** + * Tests for {@link WebMvcTest} with a disabled filter registration. + * + * @author Andy Wilkinson + */ +@RunWith(SpringRunner.class) +@WebMvcTest +public class WebMvcTestServletFilterRegistrationDisabledIntegrationTests { + + @Autowired + private MockMvc mvc; + + @Test + public void shouldApplyFilter() throws Exception { + this.mvc.perform(get("/one")).andExpect(header().string("x-test", (String) null)); + } + + @TestConfiguration + static class DisabledRegistrationConfiguration { + + @Bean + public FilterRegistrationBean exampleFilterRegistration( + ExampleFilter filter) { + FilterRegistrationBean registration = new FilterRegistrationBean<>( + filter); + registration.setEnabled(false); + return registration; + } + + } + +}