From 91acd957b2b44664ab113b8461ceefa8356d988b Mon Sep 17 00:00:00 2001 From: Scott Frederick Date: Wed, 7 Oct 2020 18:18:21 -0500 Subject: [PATCH] Disable docker registry integration tests A docker registry running in testcontainers behaves differently in CI vs running locally. Disabling the tests for now while working on getting them running reliably in CI. See gh-21001 --- .../tasks/bundling/BootBuildImageRegistryIntegrationTests.java | 2 ++ .../boot/maven/BuildImageRegistryIntegrationTests.java | 2 ++ 2 files changed, 4 insertions(+) diff --git a/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/tasks/bundling/BootBuildImageRegistryIntegrationTests.java b/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/tasks/bundling/BootBuildImageRegistryIntegrationTests.java index f3678363d2..eb94cb15ec 100644 --- a/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/tasks/bundling/BootBuildImageRegistryIntegrationTests.java +++ b/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/tasks/bundling/BootBuildImageRegistryIntegrationTests.java @@ -25,6 +25,7 @@ import java.time.Duration; import org.gradle.testkit.runner.BuildResult; import org.gradle.testkit.runner.TaskOutcome; import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.TestTemplate; import org.testcontainers.containers.GenericContainer; import org.testcontainers.junit.jupiter.Container; @@ -46,6 +47,7 @@ import static org.assertj.core.api.Assertions.assertThat; */ @GradleCompatibility @Testcontainers(disabledWithoutDocker = true) +@Disabled("Disabled until differences between running locally and in CI can be diagnosed") public class BootBuildImageRegistryIntegrationTests { @Container diff --git a/spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/intTest/java/org/springframework/boot/maven/BuildImageRegistryIntegrationTests.java b/spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/intTest/java/org/springframework/boot/maven/BuildImageRegistryIntegrationTests.java index 87b8e57c13..81f733f1fd 100644 --- a/spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/intTest/java/org/springframework/boot/maven/BuildImageRegistryIntegrationTests.java +++ b/spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/intTest/java/org/springframework/boot/maven/BuildImageRegistryIntegrationTests.java @@ -20,6 +20,7 @@ import java.time.Duration; import com.github.dockerjava.api.DockerClient; import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.TestTemplate; import org.junit.jupiter.api.extension.ExtendWith; import org.testcontainers.containers.GenericContainer; @@ -40,6 +41,7 @@ import static org.assertj.core.api.Assertions.assertThat; */ @ExtendWith(MavenBuildExtension.class) @Testcontainers(disabledWithoutDocker = true) +@Disabled("Disabled until differences between running locally and in CI can be diagnosed") public class BuildImageRegistryIntegrationTests extends AbstractArchiveIntegrationTests { @Container