Unify method visibility of private classes

Apply checkstyle rule to ensure that private and package private
classes do not have unnecessary public methods. Test classes have
also been unified as much as possible to use default scoped
inner-classes.

Closes gh-7316
This commit is contained in:
Phillip Webb
2019-07-01 12:29:51 -07:00
parent 0a02a3a19c
commit a66c4d3096
910 changed files with 3754 additions and 3945 deletions

View File

@@ -360,7 +360,7 @@ class PropertiesLauncherTests {
};
}
public static class TestLoader extends URLClassLoader {
static class TestLoader extends URLClassLoader {
TestLoader(ClassLoader parent) {
super(new URL[0], parent);

View File

@@ -88,7 +88,7 @@ class CentralDirectoryParserTests {
assertThat(headers.hasNext()).isFalse();
}
private static class Collector implements CentralDirectoryVisitor {
static class Collector implements CentralDirectoryVisitor {
private List<CentralDirectoryFileHeader> headers = new ArrayList<>();
@@ -105,13 +105,13 @@ class CentralDirectoryParserTests {
public void visitEnd() {
}
public List<CentralDirectoryFileHeader> getHeaders() {
List<CentralDirectoryFileHeader> getHeaders() {
return this.headers;
}
}
private static class MockCentralDirectoryVisitor implements CentralDirectoryVisitor {
static class MockCentralDirectoryVisitor implements CentralDirectoryVisitor {
private final List<String> invocations = new ArrayList<>();
@@ -130,7 +130,7 @@ class CentralDirectoryParserTests {
this.invocations.add("visitEnd");
}
public List<String> getInvocations() {
List<String> getInvocations() {
return this.invocations;
}