Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Handle Kafka servers as strings and rely on Kafka's parsing

Browse Source 
Closes gh-34770
This commit is contained in:
Andy Wilkinson
2023-05-02 08:37:23 +01:00
parent dc4efaf276
commit b1d0433d74
7 changed files with 29 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spring-boot-project/spring-boot-testcontainers/src/main/java/org/springframework/boot/testcontainers/service/connection/kafka/KafkaContainerConnectionDetailsFactory.java
View File

@@ -16,7 +16,6 @@
package org.springframework.boot.testcontainers.service.connection.kafka;
import java.net.URI;
import java.util.List;
import org.testcontainers.containers.KafkaContainer;
@@ -53,9 +52,8 @@ class KafkaContainerConnectionDetailsFactory
}
@Override
public List<Node> getBootstrapNodes() {
URI uri = URI.create(getContainer().getBootstrapServers());
return List.of(new Node(uri.getHost(), uri.getPort()));
public List<String> getBootstrapServers() {
return List.of(getContainer().getBootstrapServers());
}
}

6
spring-boot-project/spring-boot-testcontainers/src/main/java/org/springframework/boot/testcontainers/service/connection/redpanda/RedpandaContainerConnectionDetailsFactory.java
View File

@@ -16,7 +16,6 @@
package org.springframework.boot.testcontainers.service.connection.redpanda;
import java.net.URI;
import java.util.List;
import org.testcontainers.redpanda.RedpandaContainer;
@@ -52,9 +51,8 @@ class RedpandaContainerConnectionDetailsFactory
}
@Override
public List<Node> getBootstrapNodes() {
URI uri = URI.create(getContainer().getBootstrapServers());
return List.of(new Node(uri.getHost(), uri.getPort()));
public List<String> getBootstrapServers() {
return List.of(getContainer().getBootstrapServers());
}
}