From b69455648358d54cefbc0000fb9d138f584128c0 Mon Sep 17 00:00:00 2001 From: Christian Dupuis Date: Thu, 19 Dec 2013 08:47:22 +0100 Subject: [PATCH] Set JMX export on by default --- .../boot/autoconfigure/jmx/JmxAutoConfiguration.java | 6 +++--- .../boot/autoconfigure/jmx/JmxAutoConfigurationTests.java | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jmx/JmxAutoConfiguration.java b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jmx/JmxAutoConfiguration.java index 1274092a44..c69dbdd54a 100644 --- a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jmx/JmxAutoConfiguration.java +++ b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jmx/JmxAutoConfiguration.java @@ -25,18 +25,18 @@ import org.springframework.context.annotation.EnableMBeanExport; import org.springframework.jmx.export.MBeanExporter; /** - * {@link EnableAutoConfiguration Auto-configuration} to enable/disiable Spring's + * {@link EnableAutoConfiguration Auto-configuration} to enable/disable Spring's * {@link EnableMBeanExport} mechanism based on configuration properties. * *

- * To enable auto export of annotation beans set spring.jmx.enabled: true. + * To disable auto export of annotation beans set spring.jmx.enabled: false. * * @author Christian Dupuis */ @Configuration @ConditionalOnClass({ MBeanExporter.class }) @ConditionalOnMissingBean({ MBeanExporter.class }) -@ConditionalOnExpression("${spring.jmx.enabled:false}") +@ConditionalOnExpression("${spring.jmx.enabled:true}") public class JmxAutoConfiguration { @Configuration diff --git a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jmx/JmxAutoConfigurationTests.java b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jmx/JmxAutoConfigurationTests.java index 6109202735..bba6f09696 100644 --- a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jmx/JmxAutoConfigurationTests.java +++ b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jmx/JmxAutoConfigurationTests.java @@ -56,8 +56,7 @@ public class JmxAutoConfigurationTests { this.context = new AnnotationConfigApplicationContext(); this.context.register(JmxAutoConfiguration.class); this.context.refresh(); - this.thrown.expect(NoSuchBeanDefinitionException.class); - this.context.getBean(MBeanExporter.class); + assertNotNull(this.context.getBean(MBeanExporter.class)); } @Test