Refine encodepassword options

Refine the options to include 'default'. Also no longer add
the prefix to all results.

Closes gh-11875
This commit is contained in:
Phillip Webb
2018-02-02 01:04:52 -08:00
parent eb83b2e0c2
commit c1c0385dbc
2 changed files with 24 additions and 7 deletions

View File

@@ -35,6 +35,7 @@ import org.springframework.boot.cli.command.options.OptionHandler;
import org.springframework.boot.cli.command.status.ExitStatus;
import org.springframework.boot.cli.util.Log;
import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder;
import org.springframework.security.crypto.factory.PasswordEncoderFactories;
import org.springframework.security.crypto.password.PasswordEncoder;
import org.springframework.security.crypto.password.Pbkdf2PasswordEncoder;
import org.springframework.util.StringUtils;
@@ -51,6 +52,8 @@ public class EncodePasswordCommand extends OptionParsingCommand {
static {
Map<String, Supplier<PasswordEncoder>> encoders = new LinkedHashMap<>();
encoders.put("default",
PasswordEncoderFactories::createDelegatingPasswordEncoder);
encoders.put("bcrypt", BCryptPasswordEncoder::new);
encoders.put("pbkdf2", Pbkdf2PasswordEncoder::new);
ENCODERS = Collections.unmodifiableMap(encoders);
@@ -69,7 +72,7 @@ public class EncodePasswordCommand extends OptionParsingCommand {
@Override
public Collection<HelpExample> getExamples() {
List<HelpExample> examples = new ArrayList<>();
examples.add(new HelpExample("To encode a password with bcrypt",
examples.add(new HelpExample("To encode a password with the default encoder",
"spring encodepassword mypassword"));
examples.add(new HelpExample("To encode a password with pbkdf2",
"spring encodepassword -a pbkdf2 mypassword"));
@@ -83,7 +86,7 @@ public class EncodePasswordCommand extends OptionParsingCommand {
@Override
protected void options() {
this.algorithm = option(Arrays.asList("algorithm", "a"),
"The algorithm to use").withRequiredArg().defaultsTo("bcrypt");
"The algorithm to use").withRequiredArg().defaultsTo("default");
}
@Override
@@ -100,7 +103,7 @@ public class EncodePasswordCommand extends OptionParsingCommand {
.collectionToCommaDelimitedString(ENCODERS.keySet()));
return ExitStatus.ERROR;
}
Log.info("{" + algorithm + "}" + encoder.get().encode(password));
Log.info(encoder.get().encode(password));
return ExitStatus.OK;
}