Polish "Add @JooqTest"

Closes gh-9343

spring-boot-test-autoconfigure/src/main/java/org/springframework/boot/test/autoconfigure/jooq/JooqTest.java

@@ -42,14 +42,13 @@ import org.springframework.transaction.annotation.Transactional;
  * Using this annotation will disable full auto-configuration and instead apply only
  * configuration relevant to jOOQ tests.
  * <p>
- * By default, tests annotated with {@code @JooqTest} will use an embedded in-memory
- * database (replacing any explicit or usually auto-configured DataSource). Since
- * jOOQ relies heavily on a Java-based schema that corresponds with the database schema,
- * that is propably not what you want. The
- * {@link AutoConfigureTestDatabase @AutoConfigureTestDatabase} annotation can be used
- * to override these settings.
+ * By default, tests annotated with {@code @JooqTest} use the configured database. If
+ * you want to replace any explicit or usually auto-configured DataSource by an embedded
+ * in-memory database, the {@link AutoConfigureTestDatabase @AutoConfigureTestDatabase}
+ * annotation can be used to override these settings.
  *
  * @author Michael Simons
+ * @author Stephane Nicoll
  * @since 2.0.0
  */
 @Target(ElementType.TYPE)
@@ -61,9 +60,9 @@ import org.springframework.transaction.annotation.Transactional;
 @TypeExcludeFilters(JooqTypeExcludeFilter.class)
 @Transactional
 @AutoConfigureJooq
-@AutoConfigureTestDatabase
 @ImportAutoConfiguration
 public @interface JooqTest {
+
 	/**
 	 * Determines if default filtering should be used with
 	 * {@link SpringBootApplication @SpringBootApplication}. By default no beans are
@@ -94,4 +93,5 @@ public @interface JooqTest {
 	 */
 	@AliasFor(annotation = ImportAutoConfiguration.class, attribute = "exclude")
 	Class<?>[] excludeAutoConfiguration() default {};
+
 }

spring-boot-test-autoconfigure/src/main/resources/META-INF/spring.factories

@@ -45,6 +45,11 @@ org.springframework.boot.autoconfigure.jdbc.JdbcTemplateAutoConfiguration,\
 org.springframework.boot.autoconfigure.liquibase.LiquibaseAutoConfiguration,\
 org.springframework.boot.autoconfigure.transaction.TransactionAutoConfiguration
 
+# AutoConfigureTestDatabase auto-configuration imports
+org.springframework.boot.test.autoconfigure.jdbc.AutoConfigureTestDatabase=\
+org.springframework.boot.test.autoconfigure.jdbc.TestDatabaseAutoConfiguration,\
+org.springframework.boot.autoconfigure.jdbc.DataSourceAutoConfiguration
+
 # AutoConfigureJooq auto-configuration imports
 org.springframework.boot.test.autoconfigure.jooq.AutoConfigureJooq=\
 org.springframework.boot.autoconfigure.flyway.FlywayAutoConfiguration,\
@@ -54,11 +59,6 @@ org.springframework.boot.autoconfigure.jooq.JooqAutoConfiguration,\
 org.springframework.boot.autoconfigure.liquibase.LiquibaseAutoConfiguration,\
 org.springframework.boot.autoconfigure.transaction.TransactionAutoConfiguration
 
-# AutoConfigureTestDatabase auto-configuration imports
-org.springframework.boot.test.autoconfigure.jdbc.AutoConfigureTestDatabase=\
-org.springframework.boot.test.autoconfigure.jdbc.TestDatabaseAutoConfiguration,\
-org.springframework.boot.autoconfigure.jdbc.DataSourceAutoConfiguration
-
 # AutoConfigureJson auto-configuration imports
 org.springframework.boot.test.autoconfigure.json.AutoConfigureJson=\
 org.springframework.boot.autoconfigure.gson.GsonAutoConfiguration,\

spring-boot-test-autoconfigure/src/test/java/org/springframework/boot/test/autoconfigure/jooq/JooqTestIntegrationTests.java

@@ -37,6 +37,7 @@ import static org.assertj.core.api.Assertions.assertThat;
 import static org.springframework.boot.test.autoconfigure.AutoConfigurationImportedCondition.importedAutoConfiguration;
 
 /**
+ * Integration tests for {@link JooqTest}.
  *
  * @author Michael Simons
  */
@@ -58,15 +59,16 @@ public class JooqTestIntegrationTests {
 
 	@Test
 	public void testDSLContext() {
-		assertThat(this.dsl.selectCount().from("INFORMATION_SCHEMA.TABLES").fetchOne(0, Integer.class)).isGreaterThan(0);
+		assertThat(this.dsl.selectCount().from("INFORMATION_SCHEMA.TABLES")
+				.fetchOne(0, Integer.class)).isGreaterThan(0);
 	}
 
 	@Test
-	public void replacesDefinedDataSourceWithEmbeddedDefault() throws Exception {
+	public void useDefinedDataSource() throws Exception {
 		String product = this.dataSource.getConnection().getMetaData()
 				.getDatabaseProductName();
-		assertThat(product).isEqualTo("H2");
-		assertThat(this.dsl.configuration().dialect()).isEqualTo(SQLDialect.H2);
+		assertThat(product).startsWith("HSQL");
+		assertThat(this.dsl.configuration().dialect()).isEqualTo(SQLDialect.HSQLDB);
 	}
 
 	@Test
@@ -86,4 +88,5 @@ public class JooqTestIntegrationTests {
 		assertThat(this.applicationContext)
 				.has(importedAutoConfiguration(LiquibaseAutoConfiguration.class));
 	}
+
 }

spring-boot-test-autoconfigure/src/test/java/org/springframework/boot/test/autoconfigure/jooq/JooqTestWithAutoConfigureTestDatabaseIntegrationTests.java

@@ -0,0 +1,57 @@
+/*
+ * Copyright 2012-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.boot.test.autoconfigure.jooq;
+
+import javax.sql.DataSource;
+
+import org.jooq.DSLContext;
+import org.jooq.SQLDialect;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.autoconfigure.jdbc.EmbeddedDatabaseConnection;
+import org.springframework.boot.test.autoconfigure.jdbc.AutoConfigureTestDatabase;
+import org.springframework.test.context.junit4.SpringRunner;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/**
+ * Integration tests for {@link JooqTest}.
+ *
+ * @author Stephane Nicoll
+ */
+@RunWith(SpringRunner.class)
+@JooqTest
+@AutoConfigureTestDatabase(connection = EmbeddedDatabaseConnection.H2)
+public class JooqTestWithAutoConfigureTestDatabaseIntegrationTests {
+
+	@Autowired
+	private DSLContext dsl;
+
+	@Autowired
+	private DataSource dataSource;
+
+	@Test
+	public void replacesAutoConfiguredDataSource() throws Exception {
+		String product = this.dataSource.getConnection().getMetaData()
+				.getDatabaseProductName();
+		assertThat(product).startsWith("H2");
+		assertThat(this.dsl.configuration().dialect()).isEqualTo(SQLDialect.H2);
+	}
+
+}