Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use hasSize() assertion in favor of length checks

Browse Source 
See gh-17874
This commit is contained in:
dreis2211
2019-08-15 09:36:29 +02:00
committed by Stephane Nicoll
parent 04b63cda8f
commit d4affd7f85
17 changed files with 36 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/ImageBannerTests.java
View File

@@ -165,7 +165,7 @@ class ImageBannerTests {
int frames = 138;
int linesPerFrame = 36;
assertThat(banner).contains("\r");
assertThat(lines.length).isEqualTo(frames * linesPerFrame - 1);
assertThat(lines).hasSize(frames * linesPerFrame - 1);
}
private int getBannerHeight(String banner) {

2
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/embedded/tomcat/TomcatReactiveWebServerFactoryTests.java
View File

@@ -185,7 +185,7 @@ class TomcatReactiveWebServerFactoryTests extends AbstractReactiveWebServerFacto
factory.addAdditionalTomcatConnectors(connectors);
this.webServer = factory.getWebServer(mock(HttpHandler.class));
Map<Service, Connector[]> connectorsByService = ((TomcatWebServer) this.webServer).getServiceConnectors();
assertThat(connectorsByService.values().iterator().next().length).isEqualTo(connectors.length + 1);
assertThat(connectorsByService.values().iterator().next()).hasSize(connectors.length + 1);
}
@Test

2
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/embedded/tomcat/TomcatServletWebServerFactoryTests.java
View File

@@ -225,7 +225,7 @@ class TomcatServletWebServerFactoryTests extends AbstractServletWebServerFactory
factory.addAdditionalTomcatConnectors(connectors);
this.webServer = factory.getWebServer();
Map<Service, Connector[]> connectorsByService = ((TomcatWebServer) this.webServer).getServiceConnectors();
assertThat(connectorsByService.values().iterator().next().length).isEqualTo(connectors.length + 1);
assertThat(connectorsByService.values().iterator().next()).hasSize(connectors.length + 1);
}
@Test

2
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/servlet/server/AbstractServletWebServerFactoryTests.java
View File

@@ -665,7 +665,7 @@ public abstract class AbstractServletWebServerFactoryTests {
getResponse(getLocalUrl("/session"));
this.webServer.stop();
File[] dirContents = sessionStoreDir.listFiles((dir, name) -> !(".".equals(name) || "..".equals(name)));
assertThat(dirContents.length).isGreaterThan(0);
assertThat(dirContents).isNotEmpty();
}
@Test