Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use hasSize() assertion in favor of length checks

Browse Source 
See gh-17874
This commit is contained in:
dreis2211
2019-08-15 09:36:29 +02:00
committed by Stephane Nicoll
parent 04b63cda8f
commit d4affd7f85
17 changed files with 36 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-boot-project/spring-boot-tools/spring-boot-loader-tools/src/test/java/org/springframework/boot/loader/tools/RepackagerTests.java
View File

@@ -296,7 +296,7 @@ class RepackagerTests {
assertThat(entry.getTime()).isEqualTo(JAN_1_1985);
entry = getEntry(file, "BOOT-INF/lib/" + libJarFileToUnpack.getName());
assertThat(entry.getComment()).startsWith("UNPACK:");
assertThat(entry.getComment().length()).isEqualTo(47);
assertThat(entry.getComment()).hasSize(47);
}
@Test

14
spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/test/java/org/springframework/boot/maven/RunArgumentsTests.java
View File

@@ -31,14 +31,14 @@ class RunArgumentsTests {
void parseNull() {
String[] args = parseArgs(null);
assertThat(args).isNotNull();
assertThat(args.length).isEqualTo(0);
assertThat(args).isEmpty();
}
@Test
void parseNullArray() {
String[] args = new RunArguments((String[]) null).asArray();
assertThat(args).isNotNull();
assertThat(args.length).isEqualTo(0);
assertThat(args).isEmpty();
}
@Test
@@ -59,13 +59,13 @@ class RunArgumentsTests {
void parseEmpty() {
String[] args = parseArgs(" ");
assertThat(args).isNotNull();
assertThat(args.length).isEqualTo(0);
assertThat(args).isEmpty();
}
@Test
void parseDebugFlags() {
String[] args = parseArgs("-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005");
assertThat(args.length).isEqualTo(2);
assertThat(args).hasSize(2);
assertThat(args[0]).isEqualTo("-Xdebug");
assertThat(args[1]).isEqualTo("-Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005");
}
@@ -73,7 +73,7 @@ class RunArgumentsTests {
@Test
void parseWithExtraSpaces() {
String[] args = parseArgs(" -Dfoo=bar -Dfoo2=bar2 ");
assertThat(args.length).isEqualTo(2);
assertThat(args).hasSize(2);
assertThat(args[0]).isEqualTo("-Dfoo=bar");
assertThat(args[1]).isEqualTo("-Dfoo2=bar2");
}
@@ -81,7 +81,7 @@ class RunArgumentsTests {
@Test
void parseWithNewLinesAndTabs() {
String[] args = parseArgs(" -Dfoo=bar \n\t\t -Dfoo2=bar2 ");
assertThat(args.length).isEqualTo(2);
assertThat(args).hasSize(2);
assertThat(args[0]).isEqualTo("-Dfoo=bar");
assertThat(args[1]).isEqualTo("-Dfoo2=bar2");
}
@@ -89,7 +89,7 @@ class RunArgumentsTests {
@Test
void quoteHandledProperly() {
String[] args = parseArgs("-Dvalue=\"My Value\" ");
assertThat(args.length).isEqualTo(1);
assertThat(args).hasSize(1);
assertThat(args[0]).isEqualTo("-Dvalue=My Value");
}