diff --git a/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/CrshAutoConfiguration.java b/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/CrshAutoConfiguration.java index ea335dd1c4..958ec11fcf 100644 --- a/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/CrshAutoConfiguration.java +++ b/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/CrshAutoConfiguration.java @@ -155,6 +155,7 @@ public class CrshAutoConfiguration { * Class to configure CRaSH to authenticate against Spring Security. */ @Configuration + @ConditionalOnExpression("'${shell.auth:spring}' == 'spring'") @ConditionalOnBean({ AuthenticationManager.class }) @AutoConfigureAfter(CrshAutoConfiguration.class) public static class AuthenticationManagerAdapterAutoConfiguration { @@ -168,7 +169,6 @@ public class CrshAutoConfiguration { } @Bean - @ConditionalOnExpression("'${shell.auth:spring}' == 'spring'") @ConditionalOnMissingBean({ CrshShellAuthenticationProperties.class }) public CrshShellAuthenticationProperties springAuthenticationProperties() { // In case no shell.auth property is provided fall back to Spring Security diff --git a/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/ShellProperties.java b/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/ShellProperties.java index fd296f7cc0..53b4cf0018 100644 --- a/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/ShellProperties.java +++ b/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/ShellProperties.java @@ -427,9 +427,8 @@ public class ShellProperties { } public void setRoles(String[] roles) { - // 'roles' can be empty. This means no special to access right to connect to + // 'roles' can be null. This means no special to access right to connect to // shell is required. - Assert.notNull(roles, "roles must not be null"); this.roles = roles; }