From f492285999c4b00f04064477ea89e40743885bd6 Mon Sep 17 00:00:00 2001 From: Andy Wilkinson Date: Mon, 29 Oct 2018 12:15:04 +0000 Subject: [PATCH] Polish "Make auto-configured applicationTaskExecutor bean lazy" Closes gh-14934 --- .../task/TaskExecutionAutoConfigurationTests.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/task/TaskExecutionAutoConfigurationTests.java b/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/task/TaskExecutionAutoConfigurationTests.java index 710b7ef9bc..cb8c26b7dd 100644 --- a/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/task/TaskExecutionAutoConfigurationTests.java +++ b/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/task/TaskExecutionAutoConfigurationTests.java @@ -20,6 +20,7 @@ import java.util.concurrent.Executor; import java.util.concurrent.Future; import java.util.function.Consumer; +import org.junit.Rule; import org.junit.Test; import org.springframework.beans.DirectFieldAccessor; @@ -29,6 +30,7 @@ import org.springframework.boot.task.TaskExecutorCustomizer; import org.springframework.boot.test.context.assertj.AssertableApplicationContext; import org.springframework.boot.test.context.runner.ApplicationContextRunner; import org.springframework.boot.test.context.runner.ContextConsumer; +import org.springframework.boot.test.rule.OutputCapture; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; import org.springframework.core.task.SyncTaskExecutor; @@ -55,6 +57,9 @@ public class TaskExecutionAutoConfigurationTests { .withConfiguration( AutoConfigurations.of(TaskExecutionAutoConfiguration.class)); + @Rule + public final OutputCapture output = new OutputCapture(); + @Test public void taskExecutorBuilderShouldApplyCustomSettings() { this.contextRunner @@ -101,11 +106,15 @@ public class TaskExecutionAutoConfigurationTests { @Test public void taskExecutorAutoConfigured() { + this.output.reset(); this.contextRunner.run((context) -> { + assertThat(this.output.toString()) + .doesNotContain("Initializing ExecutorService"); assertThat(context).hasSingleBean(Executor.class); assertThat(context).hasBean("applicationTaskExecutor"); assertThat(context).getBean("applicationTaskExecutor") .isInstanceOf(ThreadPoolTaskExecutor.class); + assertThat(this.output.toString()).contains("Initializing ExecutorService"); }); }