Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Preserve timestamps on loader directories

Browse Source 
Prior to this commit, when the Maven plugin copied
spring-boot-loader.jar to a repackaged archive the timestamps of class
files were preserved but the timestamps of directories were not
preserved. This resulted in the directories having a current timestamp.

This commit copies the directory timestamps from spring-boot-loader.jar
to the repackaged archive and adds tests to verify the proper
behavior.

See gh-20927
This commit is contained in:
Scott Frederick
2020-04-21 18:58:34 -05:00
parent e83c3b87c0
commit fa186aa15b
2 changed files with 42 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spring-boot-project/spring-boot-tools/spring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/AbstractJarWriter.java
View File

@@ -209,13 +209,21 @@ public abstract class AbstractJarWriter implements LoaderClassesWriter {
try (JarInputStream inputStream = new JarInputStream(new BufferedInputStream(loaderJar.openStream()))) {
JarEntry entry;
while ((entry = inputStream.getNextJarEntry()) != null) {
if (entry.getName().endsWith(".class")) {
if (isDirectoryEntry(entry) || isClassEntry(entry)) {
writeEntry(new JarArchiveEntry(entry), new InputStreamEntryWriter(inputStream));
}
}
}
}
private boolean isDirectoryEntry(JarEntry entry) {
return entry.isDirectory() && !entry.getName().equals("META-INF/");
}
private boolean isClassEntry(JarEntry entry) {
return entry.getName().endsWith(".class");
}
private void writeEntry(JarArchiveEntry entry, EntryWriter entryWriter) throws IOException {
writeEntry(entry, entryWriter, UnpackHandler.NEVER);
}