Commit Graph

4412 Commits

Author SHA1 Message Date
Brian Clozel
72c8e5d366 Collect HTTP trace at commit time for WebFlux
Prior to this commit, the `HttpTraceWebFilter` would collect the
response information (status and headers) for tracing purposes, after
the handling chain is done with the exchange - inside a
`doAfterSuccessOrError`.

Once the handler has processed the exchange, there is no strong
guarantee about the HTTP resources being still present. Depending on the
web server implementation, HTTP resources (including HTTP header maps)
might be recycled, because pooled in the first place.

This commit moves the collection and processing of the HTTP trace right
before the response is committed. This removes the need to handle
special cases with exceptions, since by that time all exception handlers
have processed the response and the information that we extract is the
information that's about to be written to the network.

Fixes gh-15819
2019-02-08 18:16:39 +01:00
Brian Clozel
cba6079b7b Log unhandled server exceptions in WebFlux
Prior to this commit, errors unhandled by custom `WebExceptionHandler`
and resulting in an HTTP 500 status would not be logged at ERROR level,
giving no information to developers about the actual exception.

This commit ensures that such exceptions are logged at the ERROR level
with their exception. By the time the exception hits the
`DefaultErrorWebExceptionHandler`, if the response is already committed
or if the exception is due to a client disconnecting, the error is
delegated to Framework support as Spring Boot won't be able to render an
error page as expected.

Fixes gh-15769
2019-02-08 12:25:05 +01:00
Johnny Lim
885c28891b Polish
Closes gh-15873
2019-02-08 09:20:15 +01:00
dreis2211
48295e16fc Fix assertion
Closes gh-15871
2019-02-08 08:45:12 +01:00
Madhura Bhave
dc31f617b3 Document limitations of YAML documents & profile-specific files
Fixes gh-15790
2019-02-07 16:40:53 -08:00
Andy Wilkinson
688eb894d0 Start building against Micrometer 1.1.3 snapshots
See gh-15869
2019-02-07 12:44:10 +00:00
Andy Wilkinson
4efca4a455 Start building against Spring Session Bean-SR3 snapshots
See gh-15868
2019-02-07 12:43:26 +00:00
Andy Wilkinson
01693bb1fd Start building against Spring Kafka 2.2.4 snapshots
See gh-15867
2019-02-07 12:42:45 +00:00
Andy Wilkinson
474a706cc3 Start building against Spring Integration 5.1.3 snapshots
See gh-15866
2019-02-07 12:42:09 +00:00
Andy Wilkinson
245d3cf9f4 Start building against Spring AMQP 2.1.4 snapshots
See gh-15865
2019-02-07 12:41:28 +00:00
Andy Wilkinson
96cf7b1e64 Start building against Spring Data Lovelace-SR5 snapshots
See gh-15864
2019-02-07 12:40:49 +00:00
Andy Wilkinson
333fe77f58 Start building against Spring Security 5.1.4 snapshots
See gh-15863
2019-02-07 12:40:11 +00:00
Andy Wilkinson
1f4927b65d Start building against Spring Framework 5.1.5 snapshots
See gh-15862
2019-02-07 12:39:33 +00:00
Andy Wilkinson
59c66eaf41 Correct documented path for locked synchronizer's identity hashcode
Closes gh-15847
2019-02-05 12:30:46 +00:00
Andy Wilkinson
ebcc53a9b7 Include tasks with custom triggers in scheduledtasks endpoint output
Closes gh-15815
2019-02-05 12:12:07 +00:00
Andy Wilkinson
1f67707509 Fix cast in TestRestTemplateContextCustomizer
Closes gh-15843
2019-02-05 11:39:25 +00:00
Andy Wilkinson
8a7958ef55 Do not use reflection to fall back to JDKs jar URLStreamHandler
Closes gh-15844
2019-02-05 10:59:32 +00:00
Andy Wilkinson
82bc87560c Use AssertJ’s exception assertions rather than fail
Closes gh-15761
2019-02-04 11:48:26 +00:00
Stephane Nicoll
9357a92503 Add reference to Codecentric's SOAP Web Services starter 2019-02-02 20:21:57 +01:00
Andy Wilkinson
2650a07dc9 Leave module-info.class in root of archive when repackaging
Closes gh-15810
2019-02-01 13:47:42 +00:00
Stephane Nicoll
ede23caace Polish "Inject Map directly rather than via ObjectProvider"
Closes gh-15798
2019-01-31 16:25:18 +01:00
ayudovin
3a2e85ce75 Inject Map directly rather than via ObjectProvider
See gh-15798
2019-01-31 16:24:18 +01:00
Stephane Nicoll
c5675de666 Polish "Handle AccessControlException in JspTemplateAvailabilityProvider"
Closes gh-15778
2019-01-31 16:21:48 +01:00
ayudovin
81273bdf9a Handle AccessControlException in JspTemplateAvailabilityProvider
See gh-15778
2019-01-31 16:20:19 +01:00
Stephane Nicoll
6f86a84301 Polish "Alias auto-configured TaskExecutor to make async tasks use it"
Closes gh-15748
2019-01-28 10:04:30 +01:00
Camille Vienot
d0859f1569 Alias auto-configured TaskExecutor to make async tasks use it
See gh-15748
2019-01-28 09:59:55 +01:00
Vedran Pavic
d7550d73a3 Remove duplicate code from HealthWebEndpointResponseMapper
Closes gh-15784
2019-01-25 10:38:16 +01:00
Andy Wilkinson
a172e146de Polish "Always fail fast when SSL is enabled without a key store"
Closes gh-15709
2019-01-22 11:51:29 +00:00
Raheela
62c8ac6ee8 Always fail fast when SSL is enabled without a key store
See gh-15709
2019-01-22 11:50:19 +00:00
Andy Wilkinson
e15e140f8c Polish "Fix typos in JsonContentAssert failure messages"
See gh-15752
2019-01-22 09:19:41 +00:00
Johnny Lim
3744082996 Fix typos in JsonContentAssert failure messages
Closes gh-15752
2019-01-22 09:19:25 +00:00
Stephane Nicoll
f0a20b1821 Polish contribution
Closes gh-15733
2019-01-17 16:14:15 -05:00
NAIT BELKACEM
6a0053c8bc Fix typo
See gh-15733
2019-01-17 16:11:11 -05:00
Stephane Nicoll
708ca0636f Clarify that Spring Boot uses the platform MBeanServer by default
Closes gh-15728
2019-01-17 10:58:08 -05:00
Stephane Nicoll
485bdc9901 Polish "Remove redundant interface modifiers"
Closes gh-15694
2019-01-14 08:13:08 -05:00
igor-suhorukov
2d873c78fe Remove redundant interface modifiers
See gh-15694
2019-01-14 08:12:41 -05:00
Phillip Webb
72400d3a96 Upgrade to Spring Batch 4.1.1
Closes gh-15659
2019-01-11 16:43:35 -08:00
Phillip Webb
9e58942698 Update copyright year for changed files 2019-01-11 16:42:02 -08:00
Phillip Webb
6a901199f5 Polish 2019-01-11 16:42:02 -08:00
Andy Wilkinson
f0141dadab Revert "Upgrade to Glassfish Jaxb 2.3.2"
This reverts commit 6b952f5b65.

See gh-15689
2019-01-11 16:07:03 +00:00
Andy Wilkinson
6b952f5b65 Upgrade to Glassfish Jaxb 2.3.2
Closes gh-15689
2019-01-11 14:32:38 +00:00
Andy Wilkinson
48b485161e Upgrade to Byte Buddy 1.9.7
Closes gh-15688
2019-01-11 14:32:37 +00:00
Andy Wilkinson
eb96cdffd2 Upgrade to Reactor Bom Californium-SR4
Closes gh-15687
2019-01-11 14:32:36 +00:00
Andy Wilkinson
c5e14afcd1 Upgrade to Micrometer 1.1.2
Closes gh-15686
2019-01-11 14:32:35 +00:00
Andy Wilkinson
99df485268 Merge branch '2.0.x' into 2.1.x 2019-01-11 13:26:47 +00:00
Andy Wilkinson
2af133084a Merge branch '1.5.x' into 2.0.x 2019-01-11 13:25:54 +00:00
Andy Wilkinson
6307cb5943 Disable Tomcat’s reference clearing
Closes gh-15101
2019-01-11 10:34:14 +00:00
Stephane Nicoll
e95a6e8c5c Upgrade to Spring Kafka 2.2.3
Closes gh-15414
2019-01-11 08:19:16 +01:00
Stephane Nicoll
c18a0756ac Upgrade to Spring Session Bean-SR2
Closes gh-15531
2019-01-11 08:18:11 +01:00
Stephane Nicoll
def5c15a14 Upgrade to Spring Security 5.1.3
Closes gh-15417
2019-01-11 08:17:27 +01:00