Commit Graph

857 Commits

Author SHA1 Message Date
Johnny Lim
e7cb1c63bb Fix typo
Closes gh-13755
2018-07-12 08:51:11 +02:00
Andy Wilkinson
2f952fde6c Polish 2018-06-25 12:39:31 +01:00
Andy Wilkinson
454de0bfd7 Polish 2018-06-25 12:01:17 +01:00
Andy Wilkinson
24d5209738 Polish “Close Database to reset Connection's auto commit property”
Closes gh-13559
2018-06-25 11:02:31 +01:00
Andy Wilkinson
b35e1ad232 Avoid unbounded metrics creation for requests not handled by Spring MVC
Previously, if an HTTP request that used a templated URI was handled
by something other than Spring MVC, a potentially unbounded number of
metrics would be created. This happened because, in the absence of
Spring MVC's best matching pattern attribute, MetricsFilter would fall
back to using the request's path. If the handling route was templated,
MetricsFilter would be unaware and would record different metrics for
each different path, rather than a single metric for the matching
pattern.

This cimmit updates MetricsFilter so that it falls back to using
unmapped when Spring MVC's best matching pattern attribute is not
available. This ensures that an unbounded number of metrics will no
longer be created, at the cost of losing specific metrics for requests
that are not handled by Spring MVC and that do not use a templated
path.

Closes gh-5875
2018-06-21 15:10:47 +01:00
Phillip Webb
99dad81e9a Update copyright header year for changed files 2018-05-04 12:15:13 -07:00
Phillip Webb
0a0247975c Formatting 2018-05-04 12:00:50 -07:00
Phillip Webb
4e96587dc8 Polish modifier declaration ordering
Follow that Java language specification.
2018-05-03 09:46:15 -07:00
Phillip Webb
64930d4e5b Polish caught exception names
Prefer `ex` over `e`.
2018-05-03 09:46:15 -07:00
Phillip Webb
3ee777e142 Polish ternary expressions
Consistently format ternary expressions and always favor `!=` as the
the check.
2018-05-03 09:46:15 -07:00
Andy Wilkinson
cd0e4fe945 Sanitize sun.java.command by default
Closes gh-12796
2018-04-09 17:44:51 +01:00
Phillip Webb
a8f366a554 Fix copyright header for edited files 2018-03-16 15:07:23 -07:00
Phillip Webb
798522d890 Format with Eclipse Oxygen SR2 2018-02-08 15:46:49 -08:00
Andy Wilkinson
9da6ddb253 Trace IDs of sessions created downstream of trace filter
Closes gh-11717
2018-01-29 15:24:24 +00:00
Phillip Webb
6a55623910 Polish 2017-12-13 12:21:57 -08:00
Stephane Nicoll
7fb0bd77cd Polish "Handle null Principal in AuditEvent"
Closes gh-11320
2017-12-12 08:45:20 +01:00
nklmish
6b6a01a7e7 Handle null Principal in AuditEvent
See gh-11320
2017-12-12 08:38:46 +01:00
Andy Wilkinson
654fe9a31c Use Checkstyle to police accidental use of unwanted imports
Closes gh-11271
2017-12-06 13:56:17 +00:00
Andy Wilkinson
276a9a0eec Reflect each source's values in env endpoint's response
Previously, the env endpoint would use the entire environment to
get the value of each property in a source. This meant that when
there were multiple sources with the same property, the value from
the source with the highest precedence would be used for every
source that contains the property.

This commit update the endpoint to retrieve the value from the
property source that is being described, rather than resolving it
against all the environment's property sources.

Closes gh-10883
2017-11-23 13:09:48 +00:00
Andy Wilkinson
85dc89e1b4 Make serialization of @ConfigurationProperties beans more defensive
Previously, serialization of a @ConfigurationProperties bean to JSON
would fail if:

- A property on the bean returned the bean (the bean was
  self-referential)
- An exception was thrown when attempting to retrieve a property's
  value.

This commit makes the serialization more defensive by skipping any
property that is affected by either of the problems described above.
Debug logging has been added to aid diagnosis of missing properties.

Closes gh-10846
2017-11-15 19:09:22 +00:00
Eddú Meléndez
9e5a1b32c8 Provide informative reason when rejecting request with invalid level
Previously, bad request with no reason was included in the response.
This commit introduces the reason when invalid log level is sent in the
request.

Fixes gh-10588
2017-10-13 10:54:14 +01:00
Andy Wilkinson
aca30950cf Polish "Align prefix match in BufferCounterService with DefaultCounterService"
See gh-10278
2017-09-20 06:51:22 +01:00
Venil Noronha
dcb81a3da5 Align prefix match in BufferCounterService with DefaultCounterService
Closes gh-10278
2017-09-20 06:34:29 +01:00
Madhura Bhave
86cd7275a1 MVC endpoints bean methods are @ConditionalOnMissingBean
Fixes gh-10105
2017-09-06 15:32:10 -07:00
Paul Vorbach
04ca7f137d Identify and fix incomplete assertions
Several calls to assertThat lacked a following assertion most often due
to wrong use of parenthesis.

See gh-10084
2017-08-29 13:49:28 +02:00
Andy Wilkinson
5a8a86375d Sanitize individual env entry that is matched exactly
Closes gh-9918
See gh-8282
2017-07-31 15:27:55 +01:00
Stephane Nicoll
5c13b8bf50 Separate custom schema configuration for Liquibase test
Unfortunately, creating the schema in code did not offer the right
condition to reproduce the error scenario. This commit restore the
initial intent, but separating the configuration and cleaning the
created context properly.

See gh-9862
2017-07-28 11:59:15 +02:00
Stephane Nicoll
7736cb1dc5 Fix test so that it doesn't leave a datasource hanging around
Closes gh-9862
2017-07-28 11:43:28 +02:00
Stephane Nicoll
7e21178f63 Polish "Use configured schema in Liquibase endpoint"
Closes gh-9862
2017-07-28 10:21:27 +02:00
Craig Andrews
3e13970fe0 Use configured schema in Liquibase endpoint
This commit makes sure that the Liquibase endpoint uses the configured
schema.

See gh-98£62
2017-07-28 10:21:27 +02:00
Andy Wilkinson
bbc34a676c Polish "Handle possible regexes defensively in NamePatternFilter"
Closes gh-9730
2017-07-21 17:24:01 +01:00
dbego
c29d1c756a Handle possible regexes defensively in NamePatternFilter
Previously, if a name contained part of a regex but wasn't actually
a regex, a PatternSyntaxException would be thrown and the request
would fail.

This commit updates NamePatternFilter to catch PatternSyntaxException
and treat the regex-like input as a name insteead.

See gh-9730
2017-07-21 17:21:49 +01:00
Stephane Nicoll
3f70638f1c Polish "Use getUsableSpace() in DiskSpaceHealthIndicator"
Closes gh-9544
2017-06-20 14:44:11 +02:00
Huang YunKun
158416fdd0 Use getUsableSpace() in DiskSpaceHealthIndicator
See gh-9544
2017-06-20 14:43:38 +02:00
Andy Wilkinson
9579e95868 Handle explicit disablement of management SSL correctly
Closes gh-9423
2017-06-07 13:57:59 +01:00
Phillip Webb
b9fd99e268 Polish 2017-06-02 13:47:28 -07:00
Stephane Nicoll
9fc90a809f Add missing @Test annotations 2017-06-01 13:37:05 +02:00
Stephane Nicoll
d4a0fe5ff9 Polish "Fix configuration properties output for actuator"
Closes gh-9052
2017-05-23 10:48:45 +02:00
Wesley Stratton
7d6293f79d Fix configuration properties output for actuator
See gh-9052
2017-05-23 10:48:45 +02:00
Stephane Nicoll
4cc515054e Merge branch '1.4.x' into 1.5.x 2017-05-22 11:06:40 +02:00
Stephane Nicoll
a59000354c Support for TransactionAwareCacheDecorator
This commit makes sure to unwrap any transaction aware cache before
collecting metrics for them.

Closes gh-8984
2017-05-22 11:05:39 +02:00
Phillip Webb
931ce15d7f Update copyright header dates 2017-05-09 21:43:52 -07:00
Phillip Webb
4a7dcc8786 Formatting 2017-05-09 21:43:24 -07:00
Madhura Bhave
3d836f7730 Fix test pollution 2017-05-04 12:20:21 -07:00
Madhura Bhave
189e07e9f3 Support values other than String in /env
Fixes gh-9079
2017-05-04 11:35:15 -07:00
Stephane Nicoll
5121b848e1 Making sure to stop embedded web servers in tests
Closes gh-9012
2017-05-03 11:33:42 +02:00
Phillip Webb
4d4d03ab2c Merge branch '1.4.x' into 1.5.x 2017-05-02 21:33:33 -07:00
Phillip Webb
4a95b2f174 Polish 2017-05-02 20:39:45 -07:00
Stephane Nicoll
035e27b1d1 Merge branch '1.4.x' into 1.5.x 2017-05-02 13:21:03 +02:00
Stephane Nicoll
8e5bf4b22a Polish CachePublicMetrics
CachePublicMetrics wasn't explicitly tested and was still using field
injection. This commit improves the situation in preparation of the fix
for gh-8984
2017-05-02 13:15:31 +02:00