diff --git a/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubPermissionsOperations.java b/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubPermissionsOperations.java index e637f90..e1f6995 100644 --- a/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubPermissionsOperations.java +++ b/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubPermissionsOperations.java @@ -41,9 +41,8 @@ public interface CredHubPermissionsOperations { * * @param name the name of the credential; must not be {@literal null} * @param permissions a collection of permissions to add - * @return the collection of permissions associated with the credential */ - List addPermissions(final CredentialName name, final CredentialPermission... permissions); + void addPermissions(final CredentialName name, final CredentialPermission... permissions); /** * Delete a permission associated with a credential. diff --git a/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubPermissionsTemplate.java b/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubPermissionsTemplate.java index 93221f9..83d4857 100644 --- a/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubPermissionsTemplate.java +++ b/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubPermissionsTemplate.java @@ -67,21 +67,19 @@ public class CredHubPermissionsTemplate implements CredHubPermissionsOperations } @Override - public List addPermissions(final CredentialName name, - final CredentialPermission... permissions) { + public void addPermissions(final CredentialName name, + final CredentialPermission... permissions) { Assert.notNull(name, "credential name must not be null"); final CredentialPermissions credentialPermissions = new CredentialPermissions(name, permissions); - return credHubOperations.doWithRest(new RestOperationsCallback>() { + credHubOperations.doWithRest(new RestOperationsCallback() { @Override - public List doWithRestOperations(RestOperations restOperations) { - ResponseEntity response = - restOperations.exchange(PERMISSIONS_URL_PATH, POST, - new HttpEntity<>(credentialPermissions), - CredentialPermissions.class); - - return response.getBody().getPermissions(); + public Void doWithRestOperations(RestOperations restOperations) { + restOperations.exchange(PERMISSIONS_URL_PATH, POST, + new HttpEntity<>(credentialPermissions), + CredentialPermissions.class); + return null; } }); } diff --git a/spring-credhub-core/src/test/java/org/springframework/credhub/core/CredHubPermissionsTemplateUnitTests.java b/spring-credhub-core/src/test/java/org/springframework/credhub/core/CredHubPermissionsTemplateUnitTests.java index 6bb7493..0fc4e20 100644 --- a/spring-credhub-core/src/test/java/org/springframework/credhub/core/CredHubPermissionsTemplateUnitTests.java +++ b/spring-credhub-core/src/test/java/org/springframework/credhub/core/CredHubPermissionsTemplateUnitTests.java @@ -98,17 +98,11 @@ public class CredHubPermissionsTemplateUnitTests { .operation(Operation.DELETE) .build(); - CredentialPermissions expectedResponse = new CredentialPermissions(NAME, permission1, permission2); + credHubTemplate.addPermissions(NAME, permission1, permission2); - when(restTemplate.exchange(PERMISSIONS_URL_PATH, POST, - new HttpEntity<>(expectedResponse), CredentialPermissions.class)) - .thenReturn(new ResponseEntity<>(expectedResponse, OK)); - - List response = credHubTemplate.addPermissions(NAME, permission1, permission2); - - assertThat(response).isNotNull(); - assertThat(response).hasSize(expectedResponse.getPermissions().size()); - assertThat(response).isEqualTo(expectedResponse.getPermissions()); + verify(restTemplate).exchange(PERMISSIONS_URL_PATH, POST, + new HttpEntity<>(new CredentialPermissions(NAME, permission1, permission2)), + CredentialPermissions.class); } @Test