From 34aed6b1a19e60208243fc65e5abb8b4eea7e861 Mon Sep 17 00:00:00 2001 From: Zohaib Khan Date: Wed, 3 Oct 2018 14:37:50 -0700 Subject: [PATCH 1/2] Update CredHubTemplate.java CredHub POST route for /api/v1/data returns an empty response body. --- .../org/springframework/credhub/core/CredHubTemplate.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubTemplate.java b/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubTemplate.java index 2643f58..6b514b7 100644 --- a/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubTemplate.java +++ b/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubTemplate.java @@ -296,20 +296,20 @@ public class CredHubTemplate implements CredHubOperations { } @Override - public List addPermissions(final CredentialName name, CredentialPermission... permissions) { + public void addPermissions(final CredentialName name, CredentialPermission... permissions) { Assert.notNull(name, "credential name must not be null"); final CredentialPermissions credentialPermissions = new CredentialPermissions(name, permissions); return doWithRest(new RestOperationsCallback>() { @Override - public List doWithRestOperations(RestOperations restOperations) { + public void doWithRestOperations(RestOperations restOperations) { ResponseEntity response = restOperations.exchange(PERMISSIONS_URL_PATH, POST, new HttpEntity(credentialPermissions), CredentialPermissions.class); - return response.getBody().getPermissions(); + return null; } }); } From 130f9b988a88d4fc412f3d57234ab8a8d7540815 Mon Sep 17 00:00:00 2001 From: Zohaib Khan Date: Wed, 3 Oct 2018 15:17:57 -0700 Subject: [PATCH 2/2] Update CredHubTemplate.java Fix Void --- .../java/org/springframework/credhub/core/CredHubTemplate.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubTemplate.java b/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubTemplate.java index 6b514b7..5d5cd13 100644 --- a/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubTemplate.java +++ b/spring-credhub-core/src/main/java/org/springframework/credhub/core/CredHubTemplate.java @@ -303,7 +303,7 @@ public class CredHubTemplate implements CredHubOperations { return doWithRest(new RestOperationsCallback>() { @Override - public void doWithRestOperations(RestOperations restOperations) { + public Void doWithRestOperations(RestOperations restOperations) { ResponseEntity response = restOperations.exchange(PERMISSIONS_URL_PATH, POST, new HttpEntity(credentialPermissions),