From 92e1781331f77b5ec6c7bcb8fa2d16e594426f21 Mon Sep 17 00:00:00 2001
From: Scott Frederick <sfrederick@pivotal.io>
Date: Tue, 31 Mar 2020 15:02:20 -0500
Subject: [PATCH] Polish to remove warnings

---
 .../org/springframework/credhub/support/CredHubRequest.java     | 1 -
 .../springframework/credhub/support/json/JsonCredential.java    | 1 -
 .../configuration/ClientHttpRequestFactoryFactoryTests.java     | 1 +
 .../core/certificate/CredHubCertificateTemplateUnitTests.java   | 2 +-
 .../credhub/support/CredHubRequestUnitTestsBase.java            | 2 +-
 5 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/spring-credhub-core/src/main/java/org/springframework/credhub/support/CredHubRequest.java b/spring-credhub-core/src/main/java/org/springframework/credhub/support/CredHubRequest.java
index 0b7256a..0f08e6e 100644
--- a/spring-credhub-core/src/main/java/org/springframework/credhub/support/CredHubRequest.java
+++ b/spring-credhub-core/src/main/java/org/springframework/credhub/support/CredHubRequest.java
@@ -150,7 +150,6 @@ public class CredHubRequest<T> {
 	/**
 	 * A builder that provides a fluent API for constructing {@link CredHubRequest}s.
 	 */
-	@SuppressWarnings("unchecked")
 	protected static abstract class CredHubRequestBuilder<T, R extends CredHubRequest<T>, B extends CredHubRequestBuilder<T, R, B>> {
 		private final B thisObj;
 		protected final R targetObj;
diff --git a/spring-credhub-core/src/main/java/org/springframework/credhub/support/json/JsonCredential.java b/spring-credhub-core/src/main/java/org/springframework/credhub/support/json/JsonCredential.java
index c2c91a6..f7e2990 100644
--- a/spring-credhub-core/src/main/java/org/springframework/credhub/support/json/JsonCredential.java
+++ b/spring-credhub-core/src/main/java/org/springframework/credhub/support/json/JsonCredential.java
@@ -25,7 +25,6 @@ import java.util.Map;
  *
  * @author Scott Frederick
  */
-@SuppressWarnings("javadoc")
 public class JsonCredential extends HashMap<String, Object> {
 	/**
 	 * @see HashMap#HashMap()
diff --git a/spring-credhub-core/src/test/java/org/springframework/credhub/configuration/ClientHttpRequestFactoryFactoryTests.java b/spring-credhub-core/src/test/java/org/springframework/credhub/configuration/ClientHttpRequestFactoryFactoryTests.java
index 56fcc0c..491e600 100644
--- a/spring-credhub-core/src/test/java/org/springframework/credhub/configuration/ClientHttpRequestFactoryFactoryTests.java
+++ b/spring-credhub-core/src/test/java/org/springframework/credhub/configuration/ClientHttpRequestFactoryFactoryTests.java
@@ -65,6 +65,7 @@ public class ClientHttpRequestFactoryFactoryTests {
 	}
 
 	@Test
+	@SuppressWarnings("deprecation")
 	public void nettyClientCreated() throws Exception {
 		ClientHttpRequestFactory factory = usingNetty(new ClientOptions());
 
diff --git a/spring-credhub-core/src/test/java/org/springframework/credhub/core/certificate/CredHubCertificateTemplateUnitTests.java b/spring-credhub-core/src/test/java/org/springframework/credhub/core/certificate/CredHubCertificateTemplateUnitTests.java
index 65ee1f5..fd9efb5 100644
--- a/spring-credhub-core/src/test/java/org/springframework/credhub/core/certificate/CredHubCertificateTemplateUnitTests.java
+++ b/spring-credhub-core/src/test/java/org/springframework/credhub/core/certificate/CredHubCertificateTemplateUnitTests.java
@@ -135,7 +135,7 @@ public class CredHubCertificateTemplateUnitTests {
 	public void bulkRegenerate() {
 		Map<String, List<CredentialName>> expectedResponse =
 				Collections.singletonMap(REGENERATED_CREDENTIALS_RESPONSE_FIELD,
-						Arrays.<CredentialName>asList(
+						Arrays.asList(
 								new SimpleCredentialName("example-certificate1"),
 								new SimpleCredentialName("example-certificate2")));
 
diff --git a/spring-credhub-core/src/test/java/org/springframework/credhub/support/CredHubRequestUnitTestsBase.java b/spring-credhub-core/src/test/java/org/springframework/credhub/support/CredHubRequestUnitTestsBase.java
index c8825b6..78f6756 100644
--- a/spring-credhub-core/src/test/java/org/springframework/credhub/support/CredHubRequestUnitTestsBase.java
+++ b/spring-credhub-core/src/test/java/org/springframework/credhub/support/CredHubRequestUnitTestsBase.java
@@ -51,7 +51,7 @@ public abstract class CredHubRequestUnitTestsBase {
 	}
 
 	@Test
-	@SuppressWarnings({"unchecked", "deprecation"})
+	@SuppressWarnings({"deprecation"})
 	public void serializationWithThreePermissions() {
 		requestBuilder
 				.permission(Permission.builder()