From 24f73b89c732e3e0117631a6b257fc47a2ea9fc2 Mon Sep 17 00:00:00 2001 From: Mark Paluch Date: Mon, 2 Dec 2019 12:37:40 +0100 Subject: [PATCH] DATACASS-656 - Migrate CQL generators to new CqlIdentifier. Original pull request: #167. --- .../cql/keyspace/AddColumnSpecification.java | 4 +-- .../keyspace/AlterColumnSpecification.java | 4 +-- .../keyspace/AlterKeyspaceSpecification.java | 7 ++-- .../cql/keyspace/AlterTableSpecification.java | 12 +++---- .../keyspace/AlterUserTypeSpecification.java | 10 +++--- .../keyspace/ColumnChangeSpecification.java | 3 +- .../cql/keyspace/ColumnSpecification.java | 5 ++- .../ColumnTypeChangeSpecification.java | 2 +- .../keyspace/CreateIndexSpecification.java | 6 ++-- .../keyspace/CreateTableSpecification.java | 4 +-- .../keyspace/CreateUserTypeSpecification.java | 4 +-- .../cql/keyspace/DropColumnSpecification.java | 4 +-- .../cql/keyspace/DropIndexSpecification.java | 4 +-- .../cql/keyspace/DropTableSpecification.java | 4 +-- .../keyspace/DropUserTypeSpecification.java | 4 +-- .../core/cql/keyspace/FieldSpecification.java | 4 +-- .../core/cql/keyspace/IndexDescriptor.java | 2 +- .../cql/keyspace/IndexNameSpecification.java | 2 +- .../keyspace/KeyspaceActionSpecification.java | 11 +++--- .../KeyspaceOptionsSpecification.java | 3 +- .../keyspace/RenameColumnSpecification.java | 2 +- .../core/cql/keyspace/TableDescriptor.java | 2 +- .../cql/keyspace/TableNameSpecification.java | 2 +- .../keyspace/TableOptionsSpecification.java | 2 +- .../core/cql/keyspace/TableSpecification.java | 6 ++-- .../keyspace/UserTypeNameSpecification.java | 2 +- .../cql/keyspace/UserTypeSpecification.java | 4 +-- .../CreateTableCqlGeneratorUnitTests.java | 34 +++++++++---------- 28 files changed, 78 insertions(+), 75 deletions(-) diff --git a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/AddColumnSpecification.java b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/AddColumnSpecification.java index 770f40b20..cc6bceece 100644 --- a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/AddColumnSpecification.java +++ b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/AddColumnSpecification.java @@ -15,7 +15,7 @@ */ package org.springframework.data.cassandra.core.cql.keyspace; -import org.springframework.data.cassandra.core.cql.CqlIdentifier; +import com.datastax.oss.driver.api.core.CqlIdentifier; import com.datastax.driver.core.DataType; @@ -40,7 +40,7 @@ public class AddColumnSpecification extends ColumnTypeChangeSpecification { * @return a new {@link AddColumnSpecification}. */ public static AddColumnSpecification addColumn(String name, DataType type) { - return addColumn(CqlIdentifier.of(name), type); + return addColumn(CqlIdentifier.fromCql(name), type); } /** diff --git a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/AlterColumnSpecification.java b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/AlterColumnSpecification.java index 33e848fee..d2cc76585 100644 --- a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/AlterColumnSpecification.java +++ b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/AlterColumnSpecification.java @@ -15,7 +15,7 @@ */ package org.springframework.data.cassandra.core.cql.keyspace; -import org.springframework.data.cassandra.core.cql.CqlIdentifier; +import com.datastax.oss.driver.api.core.CqlIdentifier; import com.datastax.driver.core.DataType; @@ -41,7 +41,7 @@ public class AlterColumnSpecification extends ColumnTypeChangeSpecification { * @return a new {@link AlterColumnSpecification}. */ public static AlterColumnSpecification alterColumn(String name, DataType type) { - return alterColumn(CqlIdentifier.of(name), type); + return alterColumn(CqlIdentifier.fromCql(name), type); } /** diff --git a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/AlterKeyspaceSpecification.java b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/AlterKeyspaceSpecification.java index 5d8cca3dd..f097367ca 100644 --- a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/AlterKeyspaceSpecification.java +++ b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/AlterKeyspaceSpecification.java @@ -15,6 +15,7 @@ */ package org.springframework.data.cassandra.core.cql.keyspace; +import com.datastax.oss.driver.api.core.CqlIdentifier; import lombok.EqualsAndHashCode; import org.springframework.data.cassandra.core.cql.KeyspaceIdentifier; @@ -27,7 +28,7 @@ import org.springframework.data.cassandra.core.cql.KeyspaceIdentifier; @EqualsAndHashCode(callSuper = true) public class AlterKeyspaceSpecification extends KeyspaceOptionsSpecification { - private AlterKeyspaceSpecification(KeyspaceIdentifier name) { + private AlterKeyspaceSpecification(CqlIdentifier name) { super(name); } @@ -39,7 +40,7 @@ public class AlterKeyspaceSpecification extends KeyspaceOptionsSpecification options = new LinkedHashMap<>(); - protected KeyspaceOptionsSpecification(KeyspaceIdentifier name) { + protected KeyspaceOptionsSpecification(CqlIdentifier name) { super(name); } diff --git a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/RenameColumnSpecification.java b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/RenameColumnSpecification.java index 9511264bb..8b86d0380 100644 --- a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/RenameColumnSpecification.java +++ b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/RenameColumnSpecification.java @@ -15,7 +15,7 @@ */ package org.springframework.data.cassandra.core.cql.keyspace; -import org.springframework.data.cassandra.core.cql.CqlIdentifier; +import com.datastax.oss.driver.api.core.CqlIdentifier; import org.springframework.util.Assert; /** diff --git a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableDescriptor.java b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableDescriptor.java index 5c878d41c..d122e8ef0 100644 --- a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableDescriptor.java +++ b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableDescriptor.java @@ -18,7 +18,7 @@ package org.springframework.data.cassandra.core.cql.keyspace; import java.util.List; import java.util.Map; -import org.springframework.data.cassandra.core.cql.CqlIdentifier; +import com.datastax.oss.driver.api.core.CqlIdentifier; /** * Describes a table. diff --git a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableNameSpecification.java b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableNameSpecification.java index 6158cd6f3..5c29c683c 100644 --- a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableNameSpecification.java +++ b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableNameSpecification.java @@ -15,7 +15,7 @@ */ package org.springframework.data.cassandra.core.cql.keyspace; -import org.springframework.data.cassandra.core.cql.CqlIdentifier; +import com.datastax.oss.driver.api.core.CqlIdentifier; import org.springframework.util.Assert; /** diff --git a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableOptionsSpecification.java b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableOptionsSpecification.java index 8cfb9cd32..9a5c40b2b 100644 --- a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableOptionsSpecification.java +++ b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableOptionsSpecification.java @@ -21,7 +21,7 @@ import java.util.Collections; import java.util.LinkedHashMap; import java.util.Map; -import org.springframework.data.cassandra.core.cql.CqlIdentifier; +import com.datastax.oss.driver.api.core.CqlIdentifier; import org.springframework.lang.Nullable; /** diff --git a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableSpecification.java b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableSpecification.java index c2a67d778..5f03fdc6a 100644 --- a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableSpecification.java +++ b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/keyspace/TableSpecification.java @@ -15,7 +15,7 @@ */ package org.springframework.data.cassandra.core.cql.keyspace; -import static org.springframework.data.cassandra.core.cql.CqlIdentifier.*; +import static com.datastax.oss.driver.api.core.CqlIdentifier.*; import static org.springframework.data.cassandra.core.cql.PrimaryKeyType.*; import java.util.ArrayList; @@ -23,7 +23,7 @@ import java.util.Collections; import java.util.List; import java.util.Optional; -import org.springframework.data.cassandra.core.cql.CqlIdentifier; +import com.datastax.oss.driver.api.core.CqlIdentifier; import org.springframework.data.cassandra.core.cql.Ordering; import org.springframework.data.cassandra.core.cql.PrimaryKeyType; import org.springframework.util.Assert; @@ -138,7 +138,7 @@ public class TableSpecification extends TableOptionsSpecification