diff --git a/pom.xml b/pom.xml index ce8ee5b84..1693959ba 100644 --- a/pom.xml +++ b/pom.xml @@ -77,11 +77,6 @@ - - ${project.groupId} - spring-cassandra - ${project.version} - com.datastax.cassandra cassandra-driver-core @@ -293,18 +288,6 @@ - - add-shared-source-dir - - add-test-source - - generate-test-sources - - - ../shared/src/test/java - - - @@ -379,13 +362,6 @@ **/* - - ../shared/src/test/resources - true - - **/* - - diff --git a/spring-cassandra/pom.xml b/spring-cassandra/pom.xml index 26dd63c0b..8c8fc619c 100644 --- a/spring-cassandra/pom.xml +++ b/spring-cassandra/pom.xml @@ -83,4 +83,21 @@ test + + + + + maven-jar-plugin + 2.3.1 + + + test-jar + + test-jar + + + + + + diff --git a/shared/src/test/java/org/springframework/cassandra/test/integration/support/AbstractTestJavaConfig.java b/spring-cassandra/src/test/java/org/springframework/cassandra/test/integration/support/AbstractTestJavaConfig.java similarity index 100% rename from shared/src/test/java/org/springframework/cassandra/test/integration/support/AbstractTestJavaConfig.java rename to spring-cassandra/src/test/java/org/springframework/cassandra/test/integration/support/AbstractTestJavaConfig.java diff --git a/shared/src/test/java/org/springframework/cassandra/test/integration/support/BuildProperties.java b/spring-cassandra/src/test/java/org/springframework/cassandra/test/integration/support/BuildProperties.java similarity index 79% rename from shared/src/test/java/org/springframework/cassandra/test/integration/support/BuildProperties.java rename to spring-cassandra/src/test/java/org/springframework/cassandra/test/integration/support/BuildProperties.java index 2a07fda77..e7bd1eb4f 100644 --- a/shared/src/test/java/org/springframework/cassandra/test/integration/support/BuildProperties.java +++ b/spring-cassandra/src/test/java/org/springframework/cassandra/test/integration/support/BuildProperties.java @@ -6,15 +6,23 @@ import java.util.Properties; @SuppressWarnings("serial") public class BuildProperties extends Properties { + protected String resourceName = null; + public BuildProperties() { - this("/build.properties"); + this("/" + BuildProperties.class.getName() + ".properties"); } - public BuildProperties(String resourceName) { + protected BuildProperties(String resourceName) { + this.resourceName = resourceName; + + loadProperties(); + } + + public void loadProperties() { loadProperties(resourceName); } - public void loadProperties(String resourceName) { + protected void loadProperties(String resourceName) { InputStream in = null; try { in = getClass().getResourceAsStream(resourceName); diff --git a/shared/src/test/resources/build.properties b/spring-cassandra/src/test/resources/org.springframework.cassandra.test.integration.support.BuildProperties.properties similarity index 100% rename from shared/src/test/resources/build.properties rename to spring-cassandra/src/test/resources/org.springframework.cassandra.test.integration.support.BuildProperties.properties diff --git a/spring-cassandra/src/test/resources/org/springframework/cassandra/test/integration/config/xml/FullySpecifiedKeyspaceCreatingXmlConfigTest-context.xml b/spring-cassandra/src/test/resources/org/springframework/cassandra/test/integration/config/xml/FullySpecifiedKeyspaceCreatingXmlConfigTest-context.xml index ca02147d5..d97f967ce 100644 --- a/spring-cassandra/src/test/resources/org/springframework/cassandra/test/integration/config/xml/FullySpecifiedKeyspaceCreatingXmlConfigTest-context.xml +++ b/spring-cassandra/src/test/resources/org/springframework/cassandra/test/integration/config/xml/FullySpecifiedKeyspaceCreatingXmlConfigTest-context.xml @@ -8,7 +8,7 @@ http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context-3.0.xsd"> + location="classpath:org.springframework.cassandra.test.integration.support.BuildProperties.properties,classpath:/org/springframework/cassandra/test/integration/config/xml/FullySpecifiedKeyspaceCreatingXmlConfigTest.properties" /> + location="classpath:org.springframework.cassandra.test.integration.support.BuildProperties.properties" /> diff --git a/spring-cassandra/src/test/resources/org/springframework/cassandra/test/integration/config/xml/MinimalXmlConfigTest-context.xml b/spring-cassandra/src/test/resources/org/springframework/cassandra/test/integration/config/xml/MinimalXmlConfigTest-context.xml index fb716513d..c3e6130fd 100644 --- a/spring-cassandra/src/test/resources/org/springframework/cassandra/test/integration/config/xml/MinimalXmlConfigTest-context.xml +++ b/spring-cassandra/src/test/resources/org/springframework/cassandra/test/integration/config/xml/MinimalXmlConfigTest-context.xml @@ -7,7 +7,7 @@ http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context-3.0.xsd"> + location="classpath:org.springframework.cassandra.test.integration.support.BuildProperties.properties" /> diff --git a/spring-cassandra/src/test/resources/org/springframework/cassandra/test/integration/config/xml/XmlConfigTest-context.xml b/spring-cassandra/src/test/resources/org/springframework/cassandra/test/integration/config/xml/XmlConfigTest-context.xml index ca3483d66..b40e1dfac 100644 --- a/spring-cassandra/src/test/resources/org/springframework/cassandra/test/integration/config/xml/XmlConfigTest-context.xml +++ b/spring-cassandra/src/test/resources/org/springframework/cassandra/test/integration/config/xml/XmlConfigTest-context.xml @@ -7,7 +7,7 @@ http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context-3.0.xsd"> + location="classpath:org.springframework.cassandra.test.integration.support.BuildProperties.properties" /> diff --git a/spring-data-cassandra/pom.xml b/spring-data-cassandra/pom.xml index f0f7c6d0f..01c29f55c 100644 --- a/spring-data-cassandra/pom.xml +++ b/spring-data-cassandra/pom.xml @@ -25,6 +25,16 @@ ${project.groupId} spring-cassandra + ${project.version} + + + + ${project.groupId} + spring-cassandra + ${project.version} + test-jar + + test diff --git a/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/test/integration/config/TestConfig.java b/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/test/integration/config/TestConfig.java index 8df1af695..e5abe0393 100644 --- a/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/test/integration/config/TestConfig.java +++ b/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/test/integration/config/TestConfig.java @@ -1,6 +1,5 @@ package org.springframework.data.cassandra.test.integration.config; -import org.springframework.cassandra.test.integration.support.BuildProperties; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; import org.springframework.data.cassandra.config.java.AbstractSpringDataCassandraConfiguration; @@ -9,6 +8,7 @@ import org.springframework.data.cassandra.convert.MappingCassandraConverter; import org.springframework.data.cassandra.core.CassandraDataOperations; import org.springframework.data.cassandra.core.CassandraDataTemplate; import org.springframework.data.cassandra.mapping.DefaultCassandraMappingContext; +import org.springframework.data.cassandra.test.integration.support.SpringDataBuildProperties; /** * Setup any spring configuration for unit tests @@ -19,7 +19,7 @@ import org.springframework.data.cassandra.mapping.DefaultCassandraMappingContext @Configuration public class TestConfig extends AbstractSpringDataCassandraConfiguration { - public static final BuildProperties PROPS = new BuildProperties(); + public static final SpringDataBuildProperties PROPS = new SpringDataBuildProperties(); public static final int PORT = PROPS.getCassandraPort(); public static final int RPC_PORT = PROPS.getCassandraRpcPort(); diff --git a/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/test/integration/support/SpringDataBuildProperties.java b/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/test/integration/support/SpringDataBuildProperties.java new file mode 100644 index 000000000..6e2527d27 --- /dev/null +++ b/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/test/integration/support/SpringDataBuildProperties.java @@ -0,0 +1,11 @@ +package org.springframework.data.cassandra.test.integration.support; + +import org.springframework.cassandra.test.integration.support.BuildProperties; + +@SuppressWarnings("serial") +public class SpringDataBuildProperties extends BuildProperties { + + public SpringDataBuildProperties() { + super("/" + SpringDataBuildProperties.class.getName() + ".properties"); + } +} diff --git a/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/test/integration/template/CassandraDataOperationsTest.java b/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/test/integration/template/CassandraDataOperationsTest.java index dc842eec2..1ff710eb9 100644 --- a/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/test/integration/template/CassandraDataOperationsTest.java +++ b/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/test/integration/template/CassandraDataOperationsTest.java @@ -39,9 +39,9 @@ import org.springframework.beans.factory.annotation.Autowired; import org.springframework.cassandra.core.ConsistencyLevel; import org.springframework.cassandra.core.QueryOptions; import org.springframework.cassandra.core.RetryPolicy; -import org.springframework.cassandra.test.integration.support.BuildProperties; import org.springframework.data.cassandra.core.CassandraDataOperations; import org.springframework.data.cassandra.test.integration.config.TestConfig; +import org.springframework.data.cassandra.test.integration.support.SpringDataBuildProperties; import org.springframework.data.cassandra.test.integration.table.Book; import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; @@ -65,7 +65,7 @@ public class CassandraDataOperationsTest { private static Logger log = LoggerFactory.getLogger(CassandraDataOperationsTest.class); - private final static BuildProperties PROPS = new BuildProperties(); + public static final SpringDataBuildProperties PROPS = new SpringDataBuildProperties(); private final static String CASSANDRA_CONFIG = "cassandra.yaml"; private final static String KEYSPACE_NAME = "test"; private final static String CASSANDRA_HOST = "localhost"; diff --git a/spring-data-cassandra/src/test/resources/org.springframework.data.cassandra.test.integration.support.SpringDataBuildProperties.properties b/spring-data-cassandra/src/test/resources/org.springframework.data.cassandra.test.integration.support.SpringDataBuildProperties.properties new file mode 100644 index 000000000..ba2281c73 --- /dev/null +++ b/spring-data-cassandra/src/test/resources/org.springframework.data.cassandra.test.integration.support.SpringDataBuildProperties.properties @@ -0,0 +1,4 @@ +build.cassandra.native_transport_port=@build.cassandra.native_transport_port@ +build.cassandra.rpc_port=@build.cassandra.rpc_port@ +build.cassandra.storage_port=@build.cassandra.storage_port@ +build.cassandra.ssl_storage_port=@build.cassandra.ssl_storage_port@ diff --git a/spring-data-cassandra/src/test/resources/org/springframework/data/cassandra/test/integration/config/cassandra.properties b/spring-data-cassandra/src/test/resources/org/springframework/data/cassandra/test/integration/config/cassandra.properties index 242812e68..358cf0041 100644 --- a/spring-data-cassandra/src/test/resources/org/springframework/data/cassandra/test/integration/config/cassandra.properties +++ b/spring-data-cassandra/src/test/resources/org/springframework/data/cassandra/test/integration/config/cassandra.properties @@ -1,3 +1,3 @@ cassandra.contactPoints=localhost -cassandra.native_transport_port=${build.cassandra.native_transport_port} +cassandra.native_transport_port=@build.cassandra.native_transport_port@ cassandra.keyspace=TestKS123 diff --git a/spring-data-cassandra/src/test/resources/org/springframework/data/cassandra/test/integration/repository/UserRepositoryIntegrationTests-context.xml b/spring-data-cassandra/src/test/resources/org/springframework/data/cassandra/test/integration/repository/UserRepositoryIntegrationTests-context.xml index 65c4cc4d9..019515a25 100644 --- a/spring-data-cassandra/src/test/resources/org/springframework/data/cassandra/test/integration/repository/UserRepositoryIntegrationTests-context.xml +++ b/spring-data-cassandra/src/test/resources/org/springframework/data/cassandra/test/integration/repository/UserRepositoryIntegrationTests-context.xml @@ -13,7 +13,7 @@ location="classpath:/org/springframework/data/cassandra/test/integration/repository/cassandra.properties" />