diff --git a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/StatementFactory.java b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/StatementFactory.java index ae1ac73fa..c5f2ff5f6 100644 --- a/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/StatementFactory.java +++ b/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/StatementFactory.java @@ -632,17 +632,19 @@ public class StatementFactory { StatementBuilder select = statementFactory.select(query, + converter.getMappingContext().getRequiredPersistentEntity(Group.class)); + + assertThat(select.build(ParameterHandling.INLINE).getQuery()) + .isEqualTo("SELECT * FROM group WHERE email='e@mail' LIMIT 10"); + + SimpleStatement statement = select.build(ParameterHandling.BY_INDEX); + assertThat(statement.getQuery()).isEqualTo("SELECT * FROM group WHERE email=? LIMIT ?"); + assertThat(statement.getPositionalValues()).containsExactly("e@mail", 10); + } + @Test // DATACASS-343 void shouldMapSelectQueryWithSortByEmbeddedLimitAndAllowFiltering() { diff --git a/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/repository/query/PartTreeCassandraQueryUnitTests.java b/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/repository/query/PartTreeCassandraQueryUnitTests.java index ad4c03be4..f4c65c78c 100644 --- a/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/repository/query/PartTreeCassandraQueryUnitTests.java +++ b/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/repository/query/PartTreeCassandraQueryUnitTests.java @@ -242,12 +242,12 @@ class PartTreeCassandraQueryUnitTests { assertThat(statement.getQuery()).isEqualTo("DELETE FROM person WHERE lastname=?"); } - @Test // DATACASS-512 + @Test // DATACASS-512, GH-1401 void shouldCreateExistsQuery() { SimpleStatement statement = deriveQueryFromMethod(Repo.class, "existsBy", new Class[0]); - assertThat(statement.getQuery()).isEqualTo("SELECT * FROM person LIMIT 1"); + assertThat(statement.getQuery()).isEqualTo("SELECT * FROM person LIMIT ?"); } private String deriveQueryFromMethod(String method, Object... args) { diff --git a/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/repository/query/ReactivePartTreeCassandraQueryUnitTests.java b/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/repository/query/ReactivePartTreeCassandraQueryUnitTests.java index ca410135f..b2315a709 100644 --- a/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/repository/query/ReactivePartTreeCassandraQueryUnitTests.java +++ b/spring-data-cassandra/src/test/java/org/springframework/data/cassandra/repository/query/ReactivePartTreeCassandraQueryUnitTests.java @@ -149,13 +149,13 @@ class ReactivePartTreeCassandraQueryUnitTests { assertThat(statement.getQuery()).isEqualTo("DELETE FROM person WHERE lastname=?"); } - @Test // DATACASS-512 + @Test // DATACASS-512, GH-1401 void shouldCreateExistsQuery() { SimpleStatement statement = deriveQueryFromMethod(PartTreeCassandraQueryUnitTests.Repo.class, "existsBy", new Class[0]); - assertThat(statement.getQuery()).isEqualTo("SELECT * FROM person LIMIT 1"); + assertThat(statement.getQuery()).isEqualTo("SELECT * FROM person LIMIT ?"); } private String deriveQueryFromMethod(String method, Object... args) {