Spring/spring-data-cassandra
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use string concatenation in QueryExtractorDelegate instead of String.format(…).

Browse Source 
We now use string concatenation during query extraction to avoid String.format(…) overhead for unknown queries.

Closes #1186
This commit is contained in:
Mark Paluch
2021-10-25 09:08:52 +02:00
parent 01c12350e3
commit ff2ebf2ec2
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/QueryExtractorDelegate.java
View File

@@ -15,8 +15,6 @@
*/ */
package org.springframework.data.cassandra.core.cql; package org.springframework.data.cassandra.core.cql;
import org.springframework.lang.Nullable;
import com.datastax.oss.driver.api.core.cql.BatchStatement; import com.datastax.oss.driver.api.core.cql.BatchStatement;
import com.datastax.oss.driver.api.core.cql.BatchableStatement; import com.datastax.oss.driver.api.core.cql.BatchableStatement;
import com.datastax.oss.driver.api.core.cql.BoundStatement; import com.datastax.oss.driver.api.core.cql.BoundStatement;
@@ -24,6 +22,9 @@ import com.datastax.oss.driver.api.core.cql.PreparedStatement;
import com.datastax.oss.driver.api.core.cql.SimpleStatement; import com.datastax.oss.driver.api.core.cql.SimpleStatement;
import com.datastax.oss.driver.api.core.cql.Statement; import com.datastax.oss.driver.api.core.cql.Statement;
import org.springframework.lang.Nullable;
import org.springframework.util.ObjectUtils;
/** /**
* Utility to extract CQL queries from a {@link Statement}. * Utility to extract CQL queries from a {@link Statement}.
* *
@@ -68,12 +69,16 @@ public class QueryExtractorDelegate {
for (BatchableStatement<?> batchableStatement : ((BatchStatement) statement)) { for (BatchableStatement<?> batchableStatement : ((BatchStatement) statement)) {
String query = getCql(batchableStatement); String query = getCql(batchableStatement);
builder.append(query).append(query.endsWith(";") ? "" : ";"); builder.append(query);
if (!ObjectUtils.isEmpty(query)) {
builder.append(query.endsWith(";") ? "" : ";");
}
} }
return builder.toString(); return builder.toString();
} }
return String.format("Unknown: %s", statement); return "Unknown: " + statement;
} }
} }