From 02e884ed9db5221fc7ade5e95b40658bdc448270 Mon Sep 17 00:00:00 2001
From: Oliver Gierke <info@olivergierke.de>
Date: Thu, 13 Oct 2011 16:43:32 +0200
Subject: [PATCH] =?UTF-8?q?DATACMNS-87=20-=20Avoid=20creating=20Persistent?=
 =?UTF-8?q?Entity=20for=20leaf=20property=20in=20AbstractMappingContext.ge?=
 =?UTF-8?q?tPersistentPropertyPath(=E2=80=A6).?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../context/AbstractMappingContext.java       |  7 +-
 .../AbstractMappingContextUnitTest.java       | 68 +++++++++++++++++++
 2 files changed, 73 insertions(+), 2 deletions(-)
 create mode 100644 spring-data-commons-core/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTest.java

diff --git a/spring-data-commons-core/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java b/spring-data-commons-core/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java
index c513d7293..d950a98f5 100644
--- a/spring-data-commons-core/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java
+++ b/spring-data-commons-core/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2011 by the original author(s).
+ * Copyright 2011 by the original author(s).
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -183,7 +183,10 @@ public abstract class AbstractMappingContext<E extends MutablePersistentEntity<?
 			}
 			
 			result.add(persistentProperty);
-			current = getPersistentEntity(segment.getType());
+			
+			if (segment.hasNext()) {
+				current = getPersistentEntity(segment.getType());
+			}
 		}
 		
 		return new DefaultPersistentPropertyPath<P>(result);
diff --git a/spring-data-commons-core/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTest.java b/spring-data-commons-core/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTest.java
new file mode 100644
index 000000000..48f69b667
--- /dev/null
+++ b/spring-data-commons-core/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTest.java
@@ -0,0 +1,68 @@
+package org.springframework.data.mapping.context;
+
+import static org.hamcrest.CoreMatchers.*;
+import static org.mockito.Matchers.*;
+import static org.mockito.Mockito.*;
+
+import java.beans.PropertyDescriptor;
+import java.lang.reflect.Field;
+
+import org.junit.Test;
+import org.springframework.data.mapping.PersistentProperty;
+import org.springframework.data.mapping.PropertyPath;
+import org.springframework.data.mapping.model.BasicPersistentEntity;
+import org.springframework.data.mapping.model.SimpleTypeHolder;
+import org.springframework.data.util.ClassTypeInformation;
+import org.springframework.data.util.TypeInformation;
+import org.springframework.util.Assert;
+
+/**
+ *
+ * @author Oliver Gierke
+ */
+public class AbstractMappingContextUnitTest<T extends PersistentProperty<T>> {
+	
+	final SimpleTypeHolder holder = new SimpleTypeHolder();
+	
+	@Test
+	public void doesNotTryToLookupPersistentEntityForLeafProperty() {
+		
+		DummyMappingContext context = new DummyMappingContext();
+		context.setSimpleTypeHolder(holder);
+		PersistentPropertyPath<T> path = context.getPersistentPropertyPath(PropertyPath.from("name", Person.class));
+		org.junit.Assert.assertThat(path, is(notNull()));
+	}
+
+	class Person {
+		String name;
+	}
+	
+	
+	class DummyMappingContext extends AbstractMappingContext<BasicPersistentEntity<Object, T>, T> {
+
+		@Override
+		@SuppressWarnings("unchecked")
+		protected <S> BasicPersistentEntity<Object, T> createPersistentEntity(TypeInformation<S> typeInformation) {
+			return new BasicPersistentEntity<Object, T>((TypeInformation<Object>) typeInformation) {
+				
+				@Override
+				public void verify() {
+					Assert.isTrue(!holder.isSimpleType(getType()));
+				}
+			};
+		}
+
+		@Override
+		@SuppressWarnings({ "rawtypes", "unchecked" })
+		protected T createPersistentProperty(final Field field, final PropertyDescriptor descriptor,
+				final BasicPersistentEntity<Object, T> owner, final SimpleTypeHolder simpleTypeHolder) {
+			
+			PersistentProperty prop = mock(PersistentProperty.class);
+			
+			when(prop.getTypeInformation()).thenReturn(ClassTypeInformation.from(field.getType()));
+			when(prop.getName()).thenReturn(field.getName());
+
+			return (T) prop;
+		}
+	}
+}