Spring/spring-data-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATACMNS-1615 - Polishing.

Browse Source 
Replace list creation with constant. Replace ConverterConfiguration.skipFor list with Predicate for flexible conditions. Fix typo. Simplify conditionals.

Original pull request: #421.
This commit is contained in:
Mark Paluch
2020-02-07 12:13:15 +01:00
parent dbcf9aefff
commit 09153baf62
3 changed files with 59 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/test/java/org/springframework/data/convert/CustomConversionsUnitTests.java
View File

@@ -25,6 +25,7 @@ import java.util.Arrays;
import java.util.Collections;
import java.util.Date;
import java.util.Locale;
import java.util.function.Predicate;
import org.joda.time.DateTime;
import org.junit.jupiter.api.Test;
@@ -235,7 +236,7 @@ public class CustomConversionsUnitTests {
ConverterRegistry registry = mock(ConverterRegistry.class);
ConverterConfiguration config = new ConverterConfiguration(StoreConversions.NONE, Collections.emptyList(),
Collections.singleton(new ConvertiblePair(java.time.LocalDateTime.class, Date.class)));
Predicate.<ConvertiblePair> isEqual(new ConvertiblePair(java.time.LocalDateTime.class, Date.class)).negate());
new CustomConversions(config).registerConvertersIn(registry);
verify(registry, never()).addConverter(any(LocalDateTimeToDateConverter.class));
@@ -248,7 +249,7 @@ public class CustomConversionsUnitTests {
ConverterConfiguration config = new ConverterConfiguration(StoreConversions.NONE,
Collections.singletonList(LocalDateTimeToDateConverter.INSTANCE),
Collections.singleton(new ConvertiblePair(java.time.LocalDateTime.class, Date.class)));
Predicate.<ConvertiblePair> isEqual(new ConvertiblePair(java.time.LocalDateTime.class, Date.class)).negate());
new CustomConversions(config).registerConvertersIn(registry);
verify(registry).addConverter(any(LocalDateTimeToDateConverter.class));