Spring/spring-data-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATACMNS-362 - Resolved concurrency problem in Repositories.

Browse Source 
We now create a copy of the keys before iterating over them in Repositories.getRepoInforFor(…) to make sure other threads can safely trigger lookupRepositoryFactoryInformationFor(…) which potentially alters the repositories instance variable. So far we haven't guarded against this scenario which caused a ConcurrentModificationException.
This commit is contained in:
Oliver Gierke
2013-08-26 18:29:04 +02:00
parent 0ed3fb774e
commit 1976878bd5
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/main/java/org/springframework/data/repository/support/Repositories.java
View File

@@ -173,7 +173,10 @@ public class Repositories implements Iterable<Class<?>> {
Assert.notNull(domainClass);
for (RepositoryFactoryInformation<Object, Serializable> information : repositories.keySet()) {
// Create defensive copy of the keys to allow threads to potentially add values while iterating over them
Set<RepositoryFactoryInformation<Object, Serializable>> keys = Collections.unmodifiableSet(repositories.keySet());
for (RepositoryFactoryInformation<Object, Serializable> information : keys) {
if (domainClass.equals(information.getEntityInformation().getJavaType())) {
return information;
}