From 28a5bab49af62f0d0fa4bece46ea5e84fa6d8a88 Mon Sep 17 00:00:00 2001 From: Stephane Nicoll Date: Mon, 5 Jul 2021 08:03:46 +0200 Subject: [PATCH] Polishing. A public bean method that returns a private type is unusual and prevents the processing of such bean in reflection-free use cases. There was also an unnecessary qualifier in the implementation. Closes #2399 --- .../web/config/ProjectingArgumentResolverRegistrar.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/springframework/data/web/config/ProjectingArgumentResolverRegistrar.java b/src/main/java/org/springframework/data/web/config/ProjectingArgumentResolverRegistrar.java index f0a229c36..5eaab1da7 100644 --- a/src/main/java/org/springframework/data/web/config/ProjectingArgumentResolverRegistrar.java +++ b/src/main/java/org/springframework/data/web/config/ProjectingArgumentResolverRegistrar.java @@ -54,7 +54,7 @@ public class ProjectingArgumentResolverRegistrar { * @return */ @Bean - public static ProjectingArgumentResolverBeanPostProcessor projectingArgumentResolverBeanPostProcessor( + static ProjectingArgumentResolverBeanPostProcessor projectingArgumentResolverBeanPostProcessor( @Qualifier("mvcConversionService") ObjectFactory conversionService) { return new ProjectingArgumentResolverBeanPostProcessor(conversionService); } @@ -66,7 +66,7 @@ public class ProjectingArgumentResolverRegistrar { * @author Oliver Gierke * @soundtrack Apparat With Soap & Skin - Goodbye (Dark Theme Song - https://www.youtube.com/watch?v=66VnOdk6oto) */ - private static class ProjectingArgumentResolverBeanPostProcessor + static class ProjectingArgumentResolverBeanPostProcessor implements BeanPostProcessor, BeanFactoryAware, BeanClassLoaderAware { private ProxyingHandlerMethodArgumentResolver resolver; @@ -78,8 +78,7 @@ public class ProjectingArgumentResolverRegistrar { * @param conversionService the Spring MVC {@link ConversionService} in a lazy fashion, so that its initialization * is not triggered yet. */ - public ProjectingArgumentResolverBeanPostProcessor( - @Qualifier("mvcConversionService") ObjectFactory conversionService) { + ProjectingArgumentResolverBeanPostProcessor(ObjectFactory conversionService) { this.resolver = new ProxyingHandlerMethodArgumentResolver(conversionService, false); }