diff --git a/src/main/java/org/springframework/data/repository/config/XmlRepositoryConfigurationSource.java b/src/main/java/org/springframework/data/repository/config/XmlRepositoryConfigurationSource.java index e873f8082..14e0e3992 100644 --- a/src/main/java/org/springframework/data/repository/config/XmlRepositoryConfigurationSource.java +++ b/src/main/java/org/springframework/data/repository/config/XmlRepositoryConfigurationSource.java @@ -15,8 +15,10 @@ */ package org.springframework.data.repository.config; +import java.util.ArrayList; import java.util.Arrays; import java.util.List; +import java.util.Locale; import java.util.regex.Pattern; import org.springframework.beans.factory.xml.ParserContext; @@ -173,8 +175,13 @@ public class XmlRepositoryConfigurationSource extends RepositoryConfigurationSou @Override public String getAttribute(String name) { - List parts = Arrays.asList(CAMEL_CASE_PARTS.split(name)); - String xmlAttributeName = StringUtils.collectionToDelimitedString(parts, "-"); + List lowercase = new ArrayList(); + + for (String part : Arrays.asList(CAMEL_CASE_PARTS.split(name))) { + lowercase.add(part.toLowerCase(Locale.US)); + } + + String xmlAttributeName = StringUtils.collectionToDelimitedString(lowercase, "-"); String attribute = element.getAttribute(xmlAttributeName); return StringUtils.hasText(attribute) ? attribute : null; diff --git a/src/test/java/org/springframework/data/repository/config/XmlRepositoryConfigurationSourceUnitTests.java b/src/test/java/org/springframework/data/repository/config/XmlRepositoryConfigurationSourceUnitTests.java new file mode 100644 index 000000000..1e0d6c441 --- /dev/null +++ b/src/test/java/org/springframework/data/repository/config/XmlRepositoryConfigurationSourceUnitTests.java @@ -0,0 +1,54 @@ +/* + * Copyright 2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.springframework.data.repository.config; + +import static org.hamcrest.CoreMatchers.*; +import static org.junit.Assert.*; +import static org.mockito.Matchers.*; +import static org.mockito.Mockito.*; + +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.Mock; +import org.mockito.runners.MockitoJUnitRunner; +import org.springframework.test.util.ReflectionTestUtils; +import org.w3c.dom.Element; + +/** + * Unit tests for {@link XmlRepositoryConfigurationSource}. + * + * @author Oliver Gierke + */ +@RunWith(MockitoJUnitRunner.class) +public class XmlRepositoryConfigurationSourceUnitTests { + + @Mock Element element; + + /** + * @see DATACMNS-456 + */ + @Test + public void translatesCamelCaseAttributeNameIntoXmlEquivalent() { + + RepositoryConfigurationSource source = mock(XmlRepositoryConfigurationSource.class); + ReflectionTestUtils.setField(source, "element", element); + when(source.getAttribute(anyString())).thenCallRealMethod(); + + when(element.getAttribute("some-xml-attribute")).thenReturn("value"); + + assertThat(source.getAttribute("someXmlAttribute"), is("value")); + } +}