diff --git a/spring-data-commons-core/src/main/java/org/springframework/data/repository/config/RepositoryConfig.java b/spring-data-commons-core/src/main/java/org/springframework/data/repository/config/RepositoryConfig.java index 9c3b0f4a3..f3d652f46 100644 --- a/spring-data-commons-core/src/main/java/org/springframework/data/repository/config/RepositoryConfig.java +++ b/spring-data-commons-core/src/main/java/org/springframework/data/repository/config/RepositoryConfig.java @@ -92,7 +92,7 @@ public abstract class RepositoryConfig 0; + return getRepositoryElements().size() > 0; } @@ -182,15 +182,15 @@ public abstract class RepositoryConfig getSingleRepositoryConfigInformations() { Set infos = new HashSet(); - for (Element element : getRepositoryNodes()) { - infos.add(createSingleRepositoryConfigInformationFor(element)); + for (Element repositoryElement : getRepositoryElements()) { + infos.add(createSingleRepositoryConfigInformationFor(repositoryElement)); } return infos; } - private Collection getRepositoryNodes() { + private Collection getRepositoryElements() { NodeList nodes = element.getChildNodes(); Set result = new HashSet(); diff --git a/spring-data-commons-core/src/main/java/org/springframework/data/repository/query/SimpleParameterAccessor.java b/spring-data-commons-core/src/main/java/org/springframework/data/repository/query/SimpleParameterAccessor.java index 72cb263c8..9f8e8032e 100644 --- a/spring-data-commons-core/src/main/java/org/springframework/data/repository/query/SimpleParameterAccessor.java +++ b/spring-data-commons-core/src/main/java/org/springframework/data/repository/query/SimpleParameterAccessor.java @@ -46,7 +46,7 @@ public class SimpleParameterAccessor { "Invalid number of parameters given!"); this.parameters = parameters; - this.values = values; + this.values = values.clone(); } diff --git a/spring-data-commons-core/src/main/java/org/springframework/data/repository/query/parser/AbstractQueryCreator.java b/spring-data-commons-core/src/main/java/org/springframework/data/repository/query/parser/AbstractQueryCreator.java index 2d5c05e59..f6997904a 100644 --- a/spring-data-commons-core/src/main/java/org/springframework/data/repository/query/parser/AbstractQueryCreator.java +++ b/spring-data-commons-core/src/main/java/org/springframework/data/repository/query/parser/AbstractQueryCreator.java @@ -61,7 +61,7 @@ public abstract class AbstractQueryCreator { */ public T createQuery() { - return finalize(createCriteria(tree), tree.getSort()); + return complete(createCriteria(tree), tree.getSort()); } @@ -136,5 +136,5 @@ public abstract class AbstractQueryCreator { * @param sort * @return */ - protected abstract T finalize(S criteria, Sort sort); + protected abstract T complete(S criteria, Sort sort); } diff --git a/spring-data-commons-core/src/main/java/org/springframework/data/repository/query/parser/PartTree.java b/spring-data-commons-core/src/main/java/org/springframework/data/repository/query/parser/PartTree.java index 63b2d7911..924a0cb55 100644 --- a/spring-data-commons-core/src/main/java/org/springframework/data/repository/query/parser/PartTree.java +++ b/spring-data-commons-core/src/main/java/org/springframework/data/repository/query/parser/PartTree.java @@ -116,7 +116,7 @@ public class PartTree implements Iterable { * @param keyword * @return */ - private String[] split(String text, String keyword) { + private static String[] split(String text, String keyword) { String regex = format(KEYWORD_TEMPLATE, keyword); @@ -152,7 +152,7 @@ public class PartTree implements Iterable { * * @author Oliver Gierke */ - public class OrPart implements Iterable { + public static class OrPart implements Iterable { private final List children = new ArrayList();