DATACMNS-640 - Fixed potential NullPointerException in PageableHandlerMethodArgumentResolver.

We now double check the fallback Pageable for being null before trying to lookup the Sort to fall back.
This commit is contained in:
Oliver Gierke
2015-02-04 10:32:17 +01:00
parent 57a42ababd
commit 2b4d173320
2 changed files with 25 additions and 1 deletions

View File

@@ -216,6 +216,26 @@ public class PageableHandlerMethodArgumentResolverUnitTests extends PageableDefa
.getPageNumber(), is(0));
}
/**
* @see DATACMNS-640
*/
@Test
public void usesNullSortIfNoDefaultIsConfiguredAndPageAndSizeAreGiven() {
PageableHandlerMethodArgumentResolver resolver = getResolver();
resolver.setFallbackPageable(null);
MockHttpServletRequest request = new MockHttpServletRequest();
request.addParameter("page", "0");
request.addParameter("size", "10");
Pageable result = resolver.resolveArgument(supportedMethodParameter, null, new ServletWebRequest(request), null);
assertThat(result.getPageNumber(), is(0));
assertThat(result.getPageSize(), is(10));
assertThat(result.getSort(), is(nullValue()));
}
@Override
protected PageableHandlerMethodArgumentResolver getResolver() {
PageableHandlerMethodArgumentResolver resolver = new PageableHandlerMethodArgumentResolver();