diff --git a/spring-data-commons-core/src/main/java/org/springframework/data/domain/Sort.java b/spring-data-commons-core/src/main/java/org/springframework/data/domain/Sort.java index 5a963d2bb..9102cb0dc 100644 --- a/spring-data-commons-core/src/main/java/org/springframework/data/domain/Sort.java +++ b/spring-data-commons-core/src/main/java/org/springframework/data/domain/Sort.java @@ -26,7 +26,7 @@ import org.springframework.util.StringUtils; /** * Sort option for queries. You have to provide at least a list of properties to sort for that must not include - * {@code null} or empty strings. The direction defaults to {@value Sort#DEFAULT_DIRECTION}. + * {@literal null} or empty strings. The direction defaults to {@value Sort#DEFAULT_DIRECTION}. * * @author Oliver Gierke */ @@ -35,17 +35,21 @@ public class Sort implements Iterable orders; + private final List orders; + /** + * Creates a new {@link Sort} instance using the given {@link Order}s. + * + * @param orders must not be {@literal null}. + */ public Sort(Order... orders) { - this(Arrays.asList(orders)); } /** * Creates a new {@link Sort} instance. * - * @param orders must not be {@literal null} or contain {@literal null} or empty strings + * @param orders must not be {@literal null} or contain {@literal null}. */ public Sort(List orders) { @@ -62,7 +66,6 @@ public class Sort implements Iterable() : Arrays.asList(properties)); } @@ -136,20 +138,17 @@ public class Sort implements Iterable iterator() { - return this.orders.iterator(); } /* - * (non-Javadoc) - * - * @see java.lang.Object#equals(java.lang.Object) - */ + * (non-Javadoc) + * @see java.lang.Object#equals(java.lang.Object) + */ @Override public boolean equals(Object obj) { @@ -184,7 +183,6 @@ public class Sort implements Iterable create(Direction direction, Iterable properties) { List orders = new ArrayList();