Spring/spring-data-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATACMNS-763 - Fixed constructor in example of custom repository base class.

Browse Source 
Added hint to which constructor of the superclass to override. Added test cas e to make sure the expected types are advertised in the case of an error.
This commit is contained in:
Oliver Gierke
2015-09-07 09:15:13 +02:00
parent 8992cc80a1
commit 360e473c3a
3 changed files with 48 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/test/java/org/springframework/data/repository/core/support/RepositoryFactorySupportUnitTests.java
View File

@@ -49,7 +49,9 @@ import org.springframework.data.domain.Sort;
import org.springframework.data.repository.PagingAndSortingRepository;
import org.springframework.data.repository.Repository;
import org.springframework.data.repository.RepositoryDefinition;
import org.springframework.data.repository.core.EntityInformation;
import org.springframework.data.repository.core.NamedQueries;
import org.springframework.data.repository.core.RepositoryInformation;
import org.springframework.data.repository.core.RepositoryMetadata;
import org.springframework.data.repository.query.RepositoryQuery;
import org.springframework.data.repository.sample.User;
@@ -291,7 +293,7 @@ public class RepositoryFactorySupportUnitTests {
}
/**
* @see @see DATACMNS-714
* @see DATACMNS-714
*/
@Test
public void wrapsExecutionResultIntoListenableFutureWithEntityCollectionIfConfigured() throws Exception {
@@ -303,6 +305,24 @@ public class RepositoryFactorySupportUnitTests {
expect(prepareConvertingRepository(reference).readAllByLastname("Foo"), reference);
}
/**
* @see DATACMNS-763
*/
@Test
@SuppressWarnings("rawtypes")
public void rejectsRepositoryBaseClassWithInvalidConstructor() {
RepositoryInformation information = mock(RepositoryInformation.class);
doReturn(CustomRepositoryBaseClass.class).when(information).getRepositoryBaseClass();
EntityInformation entityInformation = mock(EntityInformation.class);
exception.expect(IllegalStateException.class);
exception.expectMessage(entityInformation.getClass().getName());
exception.expectMessage(String.class.getName());
factory.getTargetRepositoryViaReflection(information, entityInformation, "Foo");
}
private ConvertingRepository prepareConvertingRepository(final Object expectedValue) {
when(factory.queryOne.execute(Mockito.any(Object[].class))).then(new Answer<Object>() {
@@ -411,4 +431,9 @@ public class RepositoryFactorySupportUnitTests {
@Async
ListenableFuture<List<User>> readAllByLastname(String lastname);
}
static class CustomRepositoryBaseClass {
public CustomRepositoryBaseClass(EntityInformation<?, ?> information) {}
}
}