DATACMNS-1827 - Consider Qualifier meta-annotated Sort method parameters.

Original pull request: #474.
This commit is contained in:
Vedran Pavic
2020-11-11 18:01:50 +01:00
committed by Mark Paluch
parent eccb067e63
commit 438b01e161
4 changed files with 82 additions and 5 deletions

View File

@@ -22,14 +22,15 @@ import java.util.List;
import java.util.Optional;
import java.util.function.Consumer;
import javax.annotation.Nullable;
import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.core.MethodParameter;
import org.springframework.core.annotation.MergedAnnotation;
import org.springframework.core.annotation.MergedAnnotations;
import org.springframework.data.domain.Sort;
import org.springframework.data.domain.Sort.Direction;
import org.springframework.data.domain.Sort.Order;
import org.springframework.data.web.SortDefault.SortDefaults;
import org.springframework.lang.Nullable;
import org.springframework.util.Assert;
import org.springframework.util.StringUtils;
@@ -41,6 +42,7 @@ import org.springframework.util.StringUtils;
* @see SortHandlerMethodArgumentResolver
* @see ReactiveSortHandlerMethodArgumentResolver
* @author Mark Paluch
* @author Vedran Pavic
*/
public abstract class SortHandlerMethodArgumentResolverSupport {
@@ -184,10 +186,10 @@ public abstract class SortHandlerMethodArgumentResolverSupport {
StringBuilder builder = new StringBuilder();
Qualifier qualifier = parameter != null ? parameter.getParameterAnnotation(Qualifier.class) : null;
String value = getQualifier(parameter);
if (qualifier != null && StringUtils.hasLength(qualifier.value())) {
builder.append(qualifier.value());
if (StringUtils.hasLength(value)) {
builder.append(value);
builder.append(qualifierDelimiter);
}
@@ -293,6 +295,19 @@ public abstract class SortHandlerMethodArgumentResolverSupport {
return StringUtils.hasText(source.replace(".", ""));
}
@Nullable
private static String getQualifier(@Nullable MethodParameter parameter) {
if (parameter == null) {
return null;
}
MergedAnnotations annotations = MergedAnnotations.from(parameter.getParameter());
MergedAnnotation<Qualifier> qualifier = annotations.get(Qualifier.class);
return qualifier.isPresent() ? qualifier.getString("value") : null;
}
/**
* Helper to easily build request parameter expressions for {@link Sort} instances.
*