From 480522bbb72d02b0791e6f3f1d2333d254523a04 Mon Sep 17 00:00:00 2001 From: Christoph Strobl Date: Tue, 30 Aug 2022 14:11:26 +0200 Subject: [PATCH] Polishing. Add issue reference and additional test for dot path resolution. Original Pull Request: #2650 --- .../binding/QuerydslPredicateBuilderUnitTests.java | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/test/java/org/springframework/data/querydsl/binding/QuerydslPredicateBuilderUnitTests.java b/src/test/java/org/springframework/data/querydsl/binding/QuerydslPredicateBuilderUnitTests.java index de2431b9d..3487ad000 100755 --- a/src/test/java/org/springframework/data/querydsl/binding/QuerydslPredicateBuilderUnitTests.java +++ b/src/test/java/org/springframework/data/querydsl/binding/QuerydslPredicateBuilderUnitTests.java @@ -182,7 +182,7 @@ class QuerydslPredicateBuilderUnitTests { assertThat(constant.getConstant()).isEqualTo("rivers,two"); } - @Test + @Test // GH-2649 void resolvesCommaSeparatedArgumentToListCorrectly() { values.add("nickNames", "Walt,Heisenberg"); @@ -194,6 +194,17 @@ class QuerydslPredicateBuilderUnitTests { assertThat(constant.getConstant()).isEqualTo(Arrays.asList("Walt", "Heisenberg")); } + @Test // GH-2649 + void resolvesCommaSeparatedArgumentToListCorrectlyForNestedPath() { + + values.add("user.nickNames", "Walt,Heisenberg"); + + var predicate = builder.getPredicate(TypeInformation.of(UserWrapper.class), values, DEFAULT_BINDINGS); + var constant = (Constant) ((List) getField(getField(predicate, "mixin"), "args")).get(0); + + assertThat(constant.getConstant()).isEqualTo(Arrays.asList("Walt", "Heisenberg")); + } + @Test // DATACMNS-883 void automaticallyInsertsAnyStepInCollectionReference() {