From 480f9ccffa52b7ad5d9f7caaee98337128f42af9 Mon Sep 17 00:00:00 2001
From: Oliver Drotbohm <odrotbohm@vmware.com>
Date: Fri, 8 Apr 2022 11:35:07 +0200
Subject: [PATCH] =?UTF-8?q?Fix=20PersistentEntity=20lookup=20in=20Abstract?=
 =?UTF-8?q?MappingContext.hasPersistentEntity(=E2=80=A6)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Looking up a PersistentEntity via ….getPersistentEntity(…) applies some massaging of the given type as it could be a proxy type created for a user type. That wrangling was not applied in ….hasPersistentEntity(…) which resulted in a call to that method with a proxy type yielding false although it shouldn't if we already have a PersistentEntity available for the corresponding user type.

We now explicitly lookup the entity by original type and, if it's not the user type itself, try to look up the entity for the latter.

Fixes #2589.
---
 .../context/AbstractMappingContext.java       | 36 ++++++++++++++++---
 .../AbstractMappingContextUnitTests.java      |  2 +-
 2 files changed, 32 insertions(+), 6 deletions(-)

diff --git a/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java b/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java
index 1d9328ac9..70eadc58d 100644
--- a/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java
+++ b/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java
@@ -218,9 +218,34 @@ public abstract class AbstractMappingContext<E extends MutablePersistentEntity<?
 
 		Assert.notNull(type, "Type must not be null!");
 
-		Optional<E> entity = persistentEntities.get(ClassTypeInformation.from(type));
+		TypeInformation<?> typeInformation = ClassTypeInformation.from(type);
 
-		return entity == null ? false : entity.isPresent();
+		try {
+
+			read.lock();
+
+			// Try the original type first
+			Optional<E> entity = persistentEntities.get(typeInformation);
+
+			if (entity != null) {
+				return entity.isPresent();
+			}
+
+			// User type is the same?
+			TypeInformation<?> userTypeInformation = typeInformation.getUserTypeInformation();
+
+			if (userTypeInformation.equals(typeInformation)) {
+				return false;
+			}
+
+			// Try the user type
+			entity = persistentEntities.get(typeInformation.getUserTypeInformation());
+
+			return entity == null ? false : entity.isPresent();
+
+		} finally {
+			read.unlock();
+		}
 	}
 
 	/*
@@ -760,7 +785,8 @@ public abstract class AbstractMappingContext<E extends MutablePersistentEntity<?
 			 */
 			public PropertyMatch(@Nullable String namePattern, @Nullable String typeName) {
 
-				Assert.isTrue(!(namePattern == null && typeName == null), "Either name pattern or type name must be given!");
+				Assert.isTrue(!((namePattern == null) && (typeName == null)),
+						"Either name pattern or type name must be given!");
 
 				this.namePattern = namePattern;
 				this.typeName = typeName;
@@ -778,11 +804,11 @@ public abstract class AbstractMappingContext<E extends MutablePersistentEntity<?
 				Assert.notNull(name, "Name must not be null!");
 				Assert.notNull(type, "Type must not be null!");
 
-				if (namePattern != null && !name.matches(namePattern)) {
+				if ((namePattern != null) && !name.matches(namePattern)) {
 					return false;
 				}
 
-				if (typeName != null && !type.getName().equals(typeName)) {
+				if ((typeName != null) && !type.getName().equals(typeName)) {
 					return false;
 				}
 
diff --git a/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTests.java b/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTests.java
index 53cb696a5..3464a28b7 100755
--- a/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTests.java
+++ b/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTests.java
@@ -334,7 +334,7 @@ class AbstractMappingContextUnitTests {
 		persistentEntity.getTypeInformation().getType().equals(Base.class);
 
 		assertThat(context.hasPersistentEntityFor(Base.class)).isTrue();
-		assertThat(context.hasPersistentEntityFor(Base$$SpringProxy$873fa2e.class)).isFalse();
+		assertThat(context.hasPersistentEntityFor(Base$$SpringProxy$873fa2e.class)).isTrue();
 
 		BasicPersistentEntity<Object, SamplePersistentProperty> persistentEntityForProxy = context
 				.getRequiredPersistentEntity(Base$$SpringProxy$873fa2e.class);