Spring/spring-data-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATACMNS-1079 - Disable generated property accessors if ClassLoader is encapsulated.

Browse Source 
ClassGeneratingPropertyAccessorFactory does not work with Java 9 (encapsulated modules, without --permit-illegal-access), because making ClassLoader.defineClass accessible fails.

Therefore this change moves call to setAccessible to the check that ensures availability of the method so isSupported(…) returns false.

Original pull request: #224.
This commit is contained in:
Jens Schauder
2017-06-02 13:55:43 +02:00
committed by Mark Paluch
parent 07da629356
commit 59f52a9e35
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java
View File

@@ -1463,7 +1463,6 @@ public class ClassGeneratingPropertyAccessorFactory implements PersistentPropert
try {
Method defineClass = getClassLoaderMethod(persistentEntity);
defineClass.setAccessible(true);
return (Class<?>) defineClass.invoke(classLoader, name, bytes, offset, len,
persistentEntity.getClass().getProtectionDomain());
@@ -1478,8 +1477,19 @@ public class ClassGeneratingPropertyAccessorFactory implements PersistentPropert
ClassLoader classLoader = entity.getType().getClassLoader();
Class<?> classLoaderClass = classLoader.getClass();
return ReflectionUtils.findMethod(classLoaderClass, "defineClass", String.class, byte[].class, Integer.TYPE,
Integer.TYPE, ProtectionDomain.class);
Method defineClass = ReflectionUtils.findMethod( //
classLoaderClass, //
"defineClass", //
String.class, //
byte[].class, //
Integer.TYPE, //
Integer.TYPE, //
ProtectionDomain.class //
);
defineClass.setAccessible(true);
return defineClass;
}
}
}