From 5b60d487e1b1522fa08c7cc68c893f2acac5928a Mon Sep 17 00:00:00 2001
From: Oliver Gierke <ogierke@pivotal.io>
Date: Wed, 13 May 2015 18:33:58 +0200
Subject: [PATCH] =?UTF-8?q?DATACMNS-695=20-=20Fixed=20potential=20NullPoin?=
 =?UTF-8?q?terException=20in=20AbstractMappingContext.getPersistentPropert?=
 =?UTF-8?q?yPath(=E2=80=A6).?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When traversing nested property paths, AbstractMappingContext.getPersistentPropertyPath(…) previously used the raw actual property type. If the property path contains a reference to a generically typed property, this causes the deeper paths not being resolved correctly.

We now explicitly use the TypeInformation of the property to retain generics information while traversing the path.
---
 .../context/AbstractMappingContext.java       |  2 +-
 .../AbstractMappingContextUnitTests.java      | 23 +++++++++++++++++++
 2 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java b/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java
index 47e9dbd85..4db922024 100644
--- a/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java
+++ b/src/main/java/org/springframework/data/mapping/context/AbstractMappingContext.java
@@ -239,7 +239,7 @@ public abstract class AbstractMappingContext<E extends MutablePersistentEntity<?
 			result.add(persistentProperty);
 
 			if (iterator.hasNext()) {
-				current = getPersistentEntity(persistentProperty.getActualType());
+				current = getPersistentEntity(persistentProperty.getTypeInformation().getActualType());
 			}
 		}
 
diff --git a/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTests.java b/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTests.java
index 7ec9bea92..01bc065c1 100644
--- a/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTests.java
+++ b/src/test/java/org/springframework/data/mapping/context/AbstractMappingContextUnitTests.java
@@ -25,6 +25,7 @@ import java.util.Iterator;
 import java.util.List;
 import java.util.TreeMap;
 
+import org.hamcrest.Matchers;
 import org.junit.Before;
 import org.junit.Test;
 import org.mockito.Mockito;
@@ -245,6 +246,15 @@ public class AbstractMappingContextUnitTests {
 		assertHasEntityFor(TreeMap.class, context, false);
 	}
 
+	/**
+	 * @see DATACMNS-695
+	 */
+	@Test
+	public void persistentPropertyPathTraversesGenericTypesCorrectly() {
+		assertThat(context.getPersistentPropertyPath("field.wrapped.field", Outer.class),
+				is(Matchers.<SamplePersistentProperty> iterableWithSize(3)));
+	}
+
 	private static void assertHasEntityFor(Class<?> type, SampleMappingContext context, boolean expected) {
 
 		boolean found = false;
@@ -283,4 +293,17 @@ public class AbstractMappingContextUnitTests {
 	static class Extension extends Base {
 		@Id String foo;
 	}
+
+	static class Outer {
+
+		Wrapper<Inner> field;
+	}
+
+	static class Wrapper<T> {
+		T wrapped;
+	}
+
+	static class Inner {
+		String field;
+	}
 }