Spring/spring-data-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATACMNS-925 - Improve memory consumption of Parameter and Parameters.

Browse Source 
This commit changes some ArrayList initializations to use an initial capacity and avoids the unnecessary fetch of the return type of a method in Parameter.isDynamicProjectionParameter().

Original pull request: #180.
This commit is contained in:
Christoph Dreis
2016-10-05 20:56:06 +02:00
committed by Oliver Gierke
parent 5bb60b6f0b
commit 62617bef05
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/org/springframework/data/repository/query/Parameter.java
View File

@@ -194,13 +194,13 @@ public class Parameter {
ClassTypeInformation<?> ownerType = ClassTypeInformation.from(parameter.getDeclaringClass());
TypeInformation<?> parameterTypes = ownerType.getParameterTypes(method).get(parameter.getParameterIndex());
TypeInformation<Object> returnType = ClassTypeInformation.fromReturnTypeOf(method);
if (!parameterTypes.getType().equals(Class.class)) {
return false;
}
TypeInformation<?> bound = parameterTypes.getTypeArguments().get(0);
TypeInformation<Object> returnType = ClassTypeInformation.fromReturnTypeOf(method);
return bound.equals(returnType.getActualType());
}

10
src/main/java/org/springframework/data/repository/query/Parameters.java
View File

@@ -62,11 +62,11 @@ public abstract class Parameters<S extends Parameters<S, T>, T extends Parameter
Assert.notNull(method);
this.parameters = new ArrayList<T>();
this.dynamicProjectionIndex = -1;
List<Class<?>> types = Arrays.asList(method.getParameterTypes());
this.parameters = new ArrayList<T>(types.size());
this.dynamicProjectionIndex = -1;
for (int i = 0; i < types.size(); i++) {
MethodParameter methodParameter = new MethodParameter(method, i);
@@ -98,12 +98,12 @@ public abstract class Parameters<S extends Parameters<S, T>, T extends Parameter
*/
protected Parameters(List<T> originals) {
this.parameters = new ArrayList<T>();
int pageableIndexTemp = -1;
int sortIndexTemp = -1;
int dynamicProjectionTemp = -1;
this.parameters = new ArrayList<T>(originals.size());
for (int i = 0; i < originals.size(); i++) {
T original = originals.get(i);