Spring/spring-data-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATACMNS-491 - Polishing of null handling API in Sort.Order.

Browse Source 
Fixed @since-tags, added author tags where appropriate, fixed copyright header in SortUnitTests. Removed unnecessary formatting line comments. Renamed nullHandlingHint to nullHandling inside Order. Changed builder method signatures to be consistent with with(…) methods defining the direction.

Fixed copy & paste test in SortUnitTests.

Original pull request: #79.
This commit is contained in:
Oliver Gierke
2014-04-28 10:23:47 +02:00
parent f689b5d5f3
commit 63e595b0af
2 changed files with 32 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/test/java/org/springframework/data/domain/SortUnitTests.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2008-2013 the original author or authors.
* Copyright 2008-2014 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -17,10 +17,10 @@ package org.springframework.data.domain;
import static org.hamcrest.CoreMatchers.*;
import static org.junit.Assert.*;
import static org.springframework.data.domain.Sort.NullHandling.*;
import org.junit.Test;
import org.springframework.data.domain.Sort.Direction;
import org.springframework.data.domain.Sort.NullHandling;
import org.springframework.data.domain.Sort.Order;
/**
@@ -28,6 +28,7 @@ import org.springframework.data.domain.Sort.Order;
*
* @author Oliver Gierke
* @author Kevin Raymond
* @author Thomas Darimont
*/
public class SortUnitTests {
@@ -137,7 +138,7 @@ public class SortUnitTests {
*/
@Test
public void orderWithNullHandlingHintNullsFirst() {
assertThat(new Order("foo").nullsFirst().getNullHandlingHint(), is(NullHandling.NULLS_FIRST));
assertThat(new Order("foo").nullsFirst().getNullHandling(), is(NULLS_FIRST));
}
/**
@@ -145,7 +146,7 @@ public class SortUnitTests {
*/
@Test
public void orderWithNullHandlingHintNullsLast() {
assertThat(new Order("foo").nullsFirst().getNullHandlingHint(), is(NullHandling.NULLS_FIRST));
assertThat(new Order("foo").nullsLast().getNullHandling(), is(NULLS_LAST));
}
/**
@@ -153,7 +154,7 @@ public class SortUnitTests {
*/
@Test
public void orderWithNullHandlingHintNullsNative() {
assertThat(new Order("foo").nullsNative().getNullHandlingHint(), is(NullHandling.NATIVE));
assertThat(new Order("foo").nullsNative().getNullHandling(), is(NATIVE));
}
/**
@@ -161,6 +162,6 @@ public class SortUnitTests {
*/
@Test
public void orderWithDefaultNullHandlingHint() {
assertThat(new Order("foo").getNullHandlingHint(), is(NullHandling.NATIVE));
assertThat(new Order("foo").getNullHandling(), is(NATIVE));
}
}