Spring/spring-data-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATACMNS-867 - Fix generic type matching for reactive repository base method discovery.

Browse Source 
Base method discovery is now aligned with blocking base method discovery to consider type variables in parameter assignability checking.

Related ticket: DATACMNS-836.
This commit is contained in:
Mark Paluch
2016-11-17 17:00:17 +01:00
committed by Oliver Gierke
parent 7c31d9916a
commit 798bbc3b0c
2 changed files with 57 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/test/java/org/springframework/data/repository/core/support/ReactiveWrapperRepositoryFactorySupportUnitTests.java
View File

@@ -38,7 +38,7 @@ import org.springframework.data.repository.reactive.ReactiveSortingRepository;
*
* @author Mark Paluch
*/
@RunWith(MockitoJUnitRunner.class)
@RunWith(MockitoJUnitRunner.Silent.class)
public class ReactiveWrapperRepositoryFactorySupportUnitTests {
public @Rule ExpectedException exception = ExpectedException.none();
@@ -69,18 +69,9 @@ public class ReactiveWrapperRepositoryFactorySupportUnitTests {
Serializable id = 1L;
ConvertingRepository repository = factory.getRepository(ConvertingRepository.class);
repository.exists(id);
repository.exists((Long) id);
verify(backingRepo, times(1)).exists(id);
}
@Test // DATACMNS-836
public void doesNotCallMethodOnBaseEvenIfDeclaredTypeCouldBeConverted() {
Long id = 1L;
ConvertingRepository repository = factory.getRepository(ConvertingRepository.class);
repository.exists(id);
verifyZeroInteractions(backingRepo);
verify(backingRepo, times(2)).exists(id);
}
@Test // DATACMNS-836