DATACMNS-1676 - Polishing.

Encapsulate field and introduce getter for ConversionService. Add missing Override annotation. Add author tags. Minor cleanups.

Original pull request: #432.
This commit is contained in:
Mark Paluch
2020-05-12 10:41:14 +02:00
parent f2f7886105
commit 7de360cb7b
3 changed files with 29 additions and 28 deletions

View File

@@ -33,22 +33,22 @@ import org.springframework.data.convert.Jsr310Converters.LocalDateTimeToDateConv
* Unit tests for {@link ReflectionAuditingBeanWrapper}.
*
* @author Oliver Gierke
* @author Pavel Horal
* @since 1.5
*/
class ReflectionAuditingBeanWrapperUnitTests {
ConversionService conversionService;
AnnotationAuditingMetadata metadata;
AnnotatedUser user;
AuditableBeanWrapper wrapper;
AuditableBeanWrapper<?> wrapper;
LocalDateTime time = LocalDateTime.now();
@BeforeEach
void setUp() {
this.conversionService = DefaultAuditableBeanWrapperFactory.getDateConversionService();
this.conversionService = new DefaultAuditableBeanWrapperFactory().getConversionService();
this.user = new AnnotatedUser();
this.wrapper = new ReflectionAuditingBeanWrapper(conversionService, user);
this.wrapper = new ReflectionAuditingBeanWrapper<>(conversionService, user);
}
@Test
@@ -76,7 +76,7 @@ class ReflectionAuditingBeanWrapperUnitTests {
}
Sample sample = new Sample();
AuditableBeanWrapper wrapper = new ReflectionAuditingBeanWrapper(conversionService, sample);
AuditableBeanWrapper<Sample> wrapper = new ReflectionAuditingBeanWrapper<>(conversionService, sample);
wrapper.setCreatedDate(time);
assertThat(sample.createdDate).isEqualTo(time.atZone(ZoneOffset.systemDefault()).toInstant().toEpochMilli());